unstable DECIMAL type

[dsavina]

In dependant doctrine library, a DECIMAL column is now bound to php type string. Therefore, retrieving such a column will return a string, ie a number properly formatted. However, once the column has been set, a float will be returned as long as the object is cached. Future queries will return a string again.

Example

// table `foo` containing column `bar`: DECIMAL(10,2)
$fooBean = $fooDao->getById(1);
echo $fooBean->getBar();
// "4.20"
$fooBean->setBar(4.1);
echo $fooBean->getBar();
// 4.1
$fooBean->setBar("4.10");
echo $fooBean->getBar();
// 4.1

The issues inferred are both an approximative precision and an unstable number format.

(cd doctrine/dbal: 9f51afa2)

Edit: typing error corrected

[moufmouf]

Wait, I'm not sure I understand...

Your example should return 4.1 and not 4.2, right? Like:

// table `foo` containing column `bar`: DECIMAL(10,2)
$fooBean = $fooDao->getById(1);
echo $fooBean->getBar();
// "4.20"
$fooBean->setBar(4.1);
echo $fooBean->getBar();
// 4.1
$fooBean->setBar("4.10");
echo $fooBean->getBar();
// 4.1

Right? Is this a typo or is 4.2 really returned?

[dsavina]

Ahah, that was a copy/pasted stupid spell check, indeed. My bad.