MdeModulePkg: Fix regressions from 11686, 11687, 11688, 11689.

11686, 11687, 11688, 11689 included some inverted conditionals
during the refactor. While the system booted, some behavior
was incorrect based on the inverted conditionals.

Signed-off-by: Aaron Pop <[email protected]>

Author: apop5

MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c

@@ -3269,7 +3269,7 @@ UiDisplayMenu (
             // If the screen has no menu items, and the user didn't select UiReset
             // ignore the selection and go back to reading keys.
             //
-            if (MenuOption != NULL ) {
+            if (MenuOption == NULL ) {
               ASSERT (MenuOption != NULL);
               break;
             }
@@ -3324,7 +3324,7 @@ UiDisplayMenu (
               break;
             }
 
-            if (MenuOption != NULL) {
+            if (MenuOption == NULL) {
               ASSERT (MenuOption != NULL);
               break;
             }
@@ -3413,7 +3413,7 @@ UiDisplayMenu (
 
       case CfUiSelect:
         ControlFlag = CfRepaint;
-        if (MenuOption != NULL ) {
+        if (MenuOption == NULL ) {
           ASSERT (MenuOption != NULL);
           break;
         }
@@ -3472,7 +3472,7 @@ UiDisplayMenu (
 
       case CfUiHotKey:
         ControlFlag = CfRepaint;
-        if (HotKey != NULL ) {
+        if (HotKey == NULL ) {
           ASSERT (HotKey != NULL);
           break;
         }

MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c

@@ -1717,7 +1717,7 @@ GetSelectionInputPopUp (
             gUserInput->InputValue.BufferLen = Question->CurrentValue.BufferLen;
           }
         } else {
-          if (CurrentOption != NULL) {
+          if (CurrentOption == NULL) {
             ASSERT (CurrentOption != NULL);
             break;
           }

MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c

@@ -1268,7 +1268,7 @@ EdbLoadCodBySymbolByIec (
         // get function name, function name is followed by char 0x09.
         //
         FieldBuffer = AsciiStrGetNewTokenField (LineBuffer, Char);
-        if (FieldBuffer != NULL) {
+        if (FieldBuffer == NULL) {
           break;
         }
 

MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c

@@ -361,7 +361,7 @@ UpdateFvFileDevicePath (
     // Build the shell device path
     //
     NewDevicePath = DevicePathFromHandle (FoundFvHandle);
-    if (NewDevicePath != NULL) {
+    if (NewDevicePath == NULL) {
       return EFI_NOT_FOUND;
     }
 

MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c

@@ -2454,7 +2454,7 @@ ParseOpCodes (
         //
         // Insert to Option list of current Question
         //
-        if (ParentStatement != NULL) {
+        if (ParentStatement == NULL) {
           break;
         }
 

MdeModulePkg/Universal/SetupBrowserDxe/Setup.c

@@ -363,7 +363,7 @@ LoadAllHiiFormset (
     // Initilize FormSet Setting
     //
     LocalFormSet = AllocateZeroPool (sizeof (FORM_BROWSER_FORMSET));
-    if (LocalFormSet != NULL ) {
+    if (LocalFormSet == NULL ) {
       ASSERT (LocalFormSet != NULL);
       return;
     }
@@ -3291,7 +3291,7 @@ ConfirmNoSubmitFail (
   }
 
   StringBuffer = AllocateZeroPool (256 * sizeof (CHAR16));
-  if (StringBuffer != NULL) {
+  if (StringBuffer == NULL) {
     ASSERT (StringBuffer != NULL);
     return RetVal;
   }
@@ -4423,7 +4423,7 @@ GetQuestionDefault (
     if (!EFI_ERROR (Status)) {
       if (HiiValue->Type == EFI_IFR_TYPE_STRING) {
         NewString = GetToken (Question->HiiValue.Value.string, FormSet->HiiHandle);
-        if (NewString != NULL) {
+        if (NewString == NULL) {
           ASSERT (NewString != NULL);
           return EFI_NOT_FOUND;
         }