EmbeddedPkg/GdbStub: Fix VS2022 type conversion warnings

Fix type conversion warnings (C4244) in GdbStub that prevent it from
building with Visual Studio 2022 when the /WX flag (treat warnings as
errors) is enabled.

Instead of adding explicit casts at every assignment, change function
parameter types from UINTN to UINT32 to match the UINT32 bitfield
definitions in the IA32_DR7 structure, as suggested by maintainer
review feedback.

Changes made:

1. EmbeddedPkg/GdbStub/GdbStubInternal.h
   - Update EnableDebugRegister() declaration: Address, Length, Type
     parameters changed from UINTN to UINT32
   - Update FindMatchingDebugRegister() declaration: Address, Length,
     Type parameters changed from UINTN to UINT32

2. EmbeddedPkg/GdbStub/X64/Processor.c
   - Update EnableDebugRegister() implementation to use UINT32
     parameters, eliminating 12 inline casts
   - Update DisableDebugRegister() to use UINT32 local variable,
     eliminating 4 inline casts
   - Update FindMatchingDebugRegister() implementation to use UINT32
     parameters
   - Update call sites to use (UINT32) casts instead of (UINTN)
   - Retain necessary (UINT32)Dr7.UintN casts (2 instances)
   - Update function documentation to reflect UINT32 parameter types

Rationale:
- Debug registers Dr0-Dr7 are 32-bit registers even on X64
- IA32_DR7 bitfields are defined as UINT32
- UINT32 parameter types reflect actual hardware constraints
- Results in cleaner code with fewer casts (net reduction of 14 casts)

Tested on:
- Windows 11 with VS2022 (X64 and IA32)
- Ubuntu with GCC5 (X64)

Addresses: #11737

Signed-off-by: Gary Beihl <[email protected]>

Author: gmbeihl

EmbeddedPkg/GdbStub/GdbStubInternal.h

@@ -676,17 +676,17 @@ EFI_STATUS
 EnableDebugRegister (
   IN  EFI_SYSTEM_CONTEXT  SystemContext,
   IN  UINTN               Register,
-  IN  UINTN               Address,
-  IN  UINTN               Length,
-  IN  UINTN               Type
+  IN  UINT32              Address,
+  IN  UINT32              Length,
+  IN  UINT32              Type
   );
 
 EFI_STATUS
 FindMatchingDebugRegister (
   IN  EFI_SYSTEM_CONTEXT  SystemContext,
-  IN  UINTN               Address,
-  IN  UINTN               Length,
-  IN  UINTN               Type,
+  IN  UINT32              Address,
+  IN  UINT32              Length,
+  IN  UINT32              Type,
   OUT UINTN               *Register
   );
 

EmbeddedPkg/GdbStub/X64/Processor.c

@@ -560,9 +560,9 @@ FindNextFreeDebugRegister (
 
   @param  SystemContext   Register content at time of the exception
   @param  Register        Register value (0 - 3)
-  @param  Address         Breakpoint address value
+  @param  Address         Breakpoint address value (UINT32)
   @param  Type            Breakpoint type (Instruction, Data write,
-                          Data read or write etc.)
+                          Data read or write etc.) (UINT32)
 
   @retval EFI_STATUS      Appropriate status value.
 
@@ -571,15 +571,15 @@ EFI_STATUS
 EnableDebugRegister (
   IN  EFI_SYSTEM_CONTEXT  SystemContext,
   IN  UINTN               Register,
-  IN  UINTN               Address,
-  IN  UINTN               Length,
-  IN  UINTN               Type
+  IN  UINT32              Address,
+  IN  UINT32              Length,
+  IN  UINT32              Type
   )
 {
   IA32_DR7  Dr7;
 
   // Convert length data
-  Length = ConvertLengthData (Length);
+  Length = (UINT32)ConvertLengthData (Length);
 
   // For Instruction execution, length should be 0
   // (Ref. Intel reference manual 18.2.4)
@@ -623,7 +623,7 @@ EnableDebugRegister (
   }
 
   // Update Dr7 with appropriate Gn, RWn and LENn bits
-  SystemContext.SystemContextIa32->Dr7 = Dr7.UintN;
+  SystemContext.SystemContextIa32->Dr7 = (UINT32)Dr7.UintN;
 
   return EFI_SUCCESS;
 }
@@ -635,10 +635,10 @@ EnableDebugRegister (
   In case of mismatch, function returns EFI_NOT_FOUND message.
 
   @param  SystemContext  Register content at time of the exception
-  @param  Address        Breakpoint address value
-  @param  Length         Breakpoint length value
+  @param  Address        Breakpoint address value (UINT32)
+  @param  Length         Breakpoint length value (UINT32)
   @param  Type           Breakpoint type (Instruction, Data write, Data read
-                         or write etc.)
+                         or write etc.) (UINT32)
   @param  Register       Register value to be returned
 
   @retval EFI_STATUS     Appropriate status value.
@@ -647,9 +647,9 @@ EnableDebugRegister (
 EFI_STATUS
 FindMatchingDebugRegister (
   IN  EFI_SYSTEM_CONTEXT  SystemContext,
-  IN  UINTN               Address,
-  IN  UINTN               Length,
-  IN  UINTN               Type,
+  IN  UINT32              Address,
+  IN  UINT32              Length,
+  IN  UINT32              Type,
   OUT UINTN               *Register
   )
 {
@@ -664,7 +664,7 @@ FindMatchingDebugRegister (
   }
 
   // Convert length data
-  Length = ConvertLengthData (Length);
+  Length = (UINT32)ConvertLengthData (Length);
 
   Dr7.UintN = SystemContext.SystemContextIa32->Dr7;
 
@@ -716,7 +716,7 @@ DisableDebugRegister (
   )
 {
   IA32_DR7  Dr7;
-  UINTN     Address = 0;
+  UINT32    Address = 0;
 
   // Read DR7 register so appropriate Gn, RWn and LENn bits can be turned off.
   Dr7.UintN = SystemContext.SystemContextIa32->Dr7;
@@ -746,7 +746,7 @@ DisableDebugRegister (
   }
 
   // Update DR7 register so appropriate Gn, RWn and LENn bits can be turned off.
-  SystemContext.SystemContextIa32->Dr7 = Dr7.UintN;
+  SystemContext.SystemContextIa32->Dr7 = (UINT32)Dr7.UintN;
 
   return EFI_SUCCESS;
 }
@@ -820,7 +820,7 @@ InsertBreakPoint (
   }
 
   // Write Address, length data at particular DR register
-  Status = EnableDebugRegister (SystemContext, Register, Address, Length, (UINTN)BreakType);
+  Status = EnableDebugRegister (SystemContext, Register, (UINT32)Address, (UINT32)Length, (UINT32)BreakType);
   if (EFI_ERROR (Status)) {
     if (Status == EFI_UNSUPPORTED) {
       Print ((CHAR16 *)L"Not supported\n");
@@ -896,7 +896,7 @@ RemoveBreakPoint (
   }
 
   // Find matching debug register
-  Status = FindMatchingDebugRegister (SystemContext, Address, Length, (UINTN)BreakType, &Register);
+  Status = FindMatchingDebugRegister (SystemContext, (UINT32)Address, (UINT32)Length, (UINT32)BreakType, &Register);
   if (EFI_ERROR (Status)) {
     if (Status == EFI_UNSUPPORTED) {
       Print ((CHAR16 *)L"Not supported.\n");