Skip to content

BaseTools: Update nasm to 2.16.01 #11844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makubacki wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −5
Open

BaseTools: Update nasm to 2.16.01 #11844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions BaseTools/Bin/nasm_ext_dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
## @file
# Download nasm x86 assembler executable tool from a nuget.org package
# - package contains different binaries based on host
# Put on the tool on the path
# Download nasm from a NuGet feed.
#
# Note:
# - The NuGet package contains different binaries for different host OSes.
#
# The versioning scheme for this nasm package is as follows:
#
# - Major version of the NuGet package encodes nasm's major and minor version (nasm_major * 10000 + nasm_minor).
# - Minor version represents the nasm revision number.
# - Revision tracks the NuGet package’s own revision (number of pushes).
#
# For example, nasm version 2.16.1 becomes 20016.1.x, where x increments with each push.
#
# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: BSD-2-Clause-Patent
Expand All @@ -12,7 +20,7 @@
"scope": "edk2-build",
"type": "nuget",
"name": "mu_nasm",
"source": "https://api.nuget.org/v3/index.json",
"version": "2.15.5",
"source": "https://pkgs.dev.azure.com/projectmu/mu/_packaging/Basetools-Binary/nuget/v3/index.json",
"version": "20016.1.1",
Copy link
Member

@mdkinney mdkinney Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the versioning scheme has changed?

Copy link
Member Author

@makubacki makubacki Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuqin12 made that change in 2023. He can comment on the details.

image

Copy link
Contributor

@kuqin12 kuqin12 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdkinney @makubacki

The versioning scheme was updated to include a wrapper version for the NuGet package itself, allowing multiple pushes for the same NASM version. In this approach:

  • Major version of the NuGet package encodes NASM’s major and minor version. (nasm_major * 10000 + nasm_minor)
  • Minor version represents the NASM revision number.
  • Revision tracks the NuGet package’s own revision (number of pushes).

For example, NASM version 2.16.1 becomes 20016.1.x, where x increments with each push.

Copy link
Member Author

@makubacki makubacki Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kuqin12. I'll include this info as a comment in the yaml file.

Copy link
Member Author

@makubacki makubacki Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the updated comment.

"flags": ["set_path", "host_specific"]
}
Loading