-
-
Notifications
You must be signed in to change notification settings - Fork 293
docs(queryParams): add info about metadata for arrays #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes add documentation and examples demonstrating array support in the QueryParams decorator, and introduce a new test endpoint ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
packages/platform/platform-params/src/decorators/queryParams.ts(2 hunks)packages/platform/platform-test-sdk/src/tests/testQueryParams.ts(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/platform/platform-test-sdk/src/tests/testQueryParams.ts (1)
packages/platform/platform-params/src/decorators/queryParams.ts (1)
QueryParams(56-66)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: test-platform (20.19.4)
- GitHub Check: lint (20.19.4)
- GitHub Check: test-specs (20.19.4)
- GitHub Check: test-security (20.19.4)
- GitHub Check: test-core (20.19.4)
- GitHub Check: test-third-parties (20.19.4)
- GitHub Check: test-graphql (20.19.4)
- GitHub Check: CodeQL-Build
- GitHub Check: test-orm (20.19.4)
🔇 Additional comments (3)
packages/platform/platform-params/src/decorators/queryParams.ts (2)
9-10: LGTM! Clear documentation of array handling requirement.The note effectively highlights that array query parameters require explicit element type specification. This aligns with the test validation added in the companion file.
28-32: LGTM! Example demonstrates the requirement clearly.The example effectively shows the correct syntax for primitive array types, which is exactly what the documentation note describes.
packages/platform/platform-test-sdk/src/tests/testQueryParams.ts (1)
51-54: LGTM! Negative test case for missing array element type.This endpoint correctly demonstrates the invalid usage pattern (missing
Stringtype specification) to validate that the framework properly rejects it, as documented in the QueryParams decorator.
|
🎉 This PR is included in version 8.18.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Information
Add info for users about QueryParams decorator: for an array, the type must be specified (even if primitive).
Todos
Summary by CodeRabbit
Documentation
Tests