feat(job): support manual jobs when schedule is empty (#75)

Add support for manual Tsuru jobs by setting the `manual` flag when the
`schedule` field is omitted. Update documentation and schema to clarify
usage. Add acceptance tests to verify manual job creation and behavior.
Cleanup test helpers and improve code formatting.

Author: ravilock

docs/resources/job.md

@@ -66,7 +66,7 @@ resource "tsuru_job" "full-featured-job" {
 - `container` (Block List, Max: 1) (see [below for nested schema](#nestedblock--container))
 - `description` (String) Job description
 - `metadata` (Block List, Max: 1) (see [below for nested schema](#nestedblock--metadata))
-- `schedule` (String) Cron-like schedule for when the job should be triggered
+- `schedule` (String) Cron-like schedule for when the job should be triggered (keep empty for manual jobs)
 - `tags` (List of String) Tags
 - `timeouts` (Block, Optional) (see [below for nested schema](#nestedblock--timeouts))
 

internal/provider/resource_tsuru_job.go

@@ -92,7 +92,7 @@ func resourceTsuruJob() *schema.Resource {
 
 			"schedule": {
 				Type:        schema.TypeString,
-				Description: "Cron-like schedule for when the job should be triggered",
+				Description: "Cron-like schedule for when the job should be triggered (keep empty for manual jobs)",
 				Optional:    true,
 			},
 
@@ -155,7 +155,6 @@ func resourceTsuruJobCreate(ctx context.Context, d *schema.ResourceData, meta in
 		}
 		return nil
 	})
-
 	if err != nil {
 		return diag.Errorf("unable to create job %s: %v", job.Name, err)
 	}
@@ -207,7 +206,6 @@ func resourceTsuruJobUpdate(ctx context.Context, d *schema.ResourceData, meta in
 
 		return nil
 	})
-
 	if err != nil {
 		return diag.Errorf("unable to update job %s: %v", jobName, err)
 	}
@@ -268,7 +266,6 @@ func resourceTsuruJobDelete(ctx context.Context, d *schema.ResourceData, meta in
 		}
 		return nil
 	})
-
 	if err != nil {
 		return diag.Errorf("unable to delete job %s: %v", name, err)
 	}
@@ -334,6 +331,8 @@ func inputJobFromResourceData(ctx context.Context, d *schema.ResourceData, provi
 
 	if schedule, ok := d.GetOk("schedule"); ok {
 		job.Schedule = schedule.(string)
+	} else {
+		job.Manual = true
 	}
 	if concurrencyPolicyInterface, ok := d.GetOk("concurrency_policy"); ok {
 		concurrencyPolicy := concurrencyPolicyInterface.(string)

internal/provider/resource_tsuru_job_test.go

@@ -110,6 +110,126 @@ func TestAccResourceTsuruJobBasic(t *testing.T) {
 	})
 }
 
+func testAccResourceTsuruJob_basic() string {
+	return `
+	resource "tsuru_job" "job" {
+		name        = "job01"
+		description = "my job description"
+		plan        = "c1m1"
+		team_owner  = "my-team"
+		pool        = "prod"
+		schedule    = "* * * * *"
+	}
+`
+}
+
+func TestAccResourceTsuruJobManual(t *testing.T) {
+	fakeServer := echo.New()
+
+	iterationCount := 0
+
+	fakeServer.GET("/1.0/pools", func(c echo.Context) error {
+		return c.JSON(http.StatusOK, []tsuru.Pool{{Name: "prod"}})
+	})
+
+	fakeServer.GET("/1.0/plans", func(c echo.Context) error {
+		return c.JSON(http.StatusOK, []tsuru.Plan{{Name: "c1m1"}})
+	})
+
+	fakeServer.POST("/1.13/jobs", func(c echo.Context) error {
+		job := tsuru.InputJob{}
+		c.Bind(&job)
+		assert.Equal(t, "job01", job.Name)
+		assert.Equal(t, "my job description", job.Description)
+		assert.Equal(t, "c1m1", job.Plan)
+		assert.Equal(t, "my-team", job.TeamOwner)
+		assert.Equal(t, "prod", job.Pool)
+		assert.Equal(t, "", job.Schedule)
+		assert.Equal(t, true, job.Manual)
+		assert.Nil(t, job.Container.Command)
+		assert.Equal(t, "", job.Container.Image)
+
+		iterationCount++
+		return c.JSON(http.StatusOK, map[string]interface{}{
+			"status":  "success",
+			"jobName": job.Name,
+		})
+	})
+
+	fakeServer.GET("/1.13/jobs/:name", func(c echo.Context) error {
+		name := c.Param("name")
+		if name != "job01" {
+			return nil
+		}
+
+		if iterationCount == 1 {
+			job := &tsuru.Job{
+				Name:        name,
+				Description: "my job description",
+				TeamOwner:   "my-team",
+				Plan:        tsuru.Plan{Name: "c1m1"},
+				Pool:        "prod",
+				Spec: tsuru.JobSpec{
+					Schedule: "",
+					Manual:   true,
+				},
+			}
+			return c.JSON(http.StatusOK, tsuru.JobInfo{Job: *job})
+		}
+
+		return c.JSON(http.StatusNotFound, nil)
+	})
+
+	fakeServer.PUT("/1.13/jobs/:name", func(c echo.Context) error {
+		return c.JSON(http.StatusOK, nil)
+	})
+
+	fakeServer.DELETE("/1.13/jobs/:name", func(c echo.Context) error {
+		name := c.Param("name")
+		assert.Equal(t, "job01", name)
+		return c.NoContent(http.StatusNoContent)
+	})
+
+	fakeServer.HTTPErrorHandler = func(err error, c echo.Context) {
+		t.Errorf("methods=%s, path=%s, err=%s", c.Request().Method, c.Path(), err.Error())
+	}
+	server := httptest.NewServer(fakeServer)
+	os.Setenv("TSURU_TARGET", server.URL)
+
+	resourceName := "tsuru_job.job"
+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviderFactories,
+		CheckDestroy:      nil,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccResourceTsuruJob_manual(),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccResourceExists(resourceName),
+					resource.TestCheckResourceAttr(resourceName, "name", "job01"),
+					resource.TestCheckResourceAttr(resourceName, "description", "my job description"),
+					resource.TestCheckResourceAttr(resourceName, "plan", "c1m1"),
+					resource.TestCheckResourceAttr(resourceName, "team_owner", "my-team"),
+					resource.TestCheckResourceAttr(resourceName, "pool", "prod"),
+					resource.TestCheckResourceAttr(resourceName, "schedule", ""),
+				),
+			},
+		},
+	})
+}
+
+func testAccResourceTsuruJob_manual() string {
+	return `
+	resource "tsuru_job" "job" {
+		name        = "job01"
+		description = "my job description"
+		plan        = "c1m1"
+		team_owner  = "my-team"
+		pool        = "prod"
+	}
+`
+}
+
 func TestAccResourceTsuruJobComplete(t *testing.T) {
 	fakeServer := echo.New()
 
@@ -220,15 +340,23 @@ func TestAccResourceTsuruJobComplete(t *testing.T) {
 	})
 }
 
-func testAccResourceTsuruJob_basic() string {
+func testAccResourceTsuruJob_complete() string {
 	return `
 	resource "tsuru_job" "job" {
-		name        = "job01"
+		name = "job01"
 		description = "my job description"
-		plan        = "c1m1"
-		team_owner  = "my-team"
-		pool        = "prod"
-		schedule    = "* * * * *"
+		plan = "c1m1"
+		team_owner = "my-team"
+		pool = "prod"
+		schedule = "* * * * *"
+		container {
+			image   = "tsuru/scratch:latest"
+			command = ["sleep", 600]
+		}
+
+
+		active_deadline_seconds = 300
+		concurrency_policy      = "Forbid"
 	}
 `
 }
@@ -407,27 +535,6 @@ func TestAccResourceTsuruJobMetadataDeletion(t *testing.T) {
 	})
 }
 
-func testAccResourceTsuruJob_complete() string {
-	return `
-	resource "tsuru_job" "job" {
-		name = "job01"
-		description = "my job description"
-		plan = "c1m1"
-		team_owner = "my-team"
-		pool = "prod"
-		schedule = "* * * * *"
-		container {
-			image   = "tsuru/scratch:latest"
-			command = ["sleep", 600]
-		}
-
-
-		active_deadline_seconds = 300
-		concurrency_policy      = "Forbid"
-	}
-`
-}
-
 func testAccResourceTsuruJob_metadata() string {
 	return `
 	resource "tsuru_job" "job" {

main.go

@@ -12,5 +12,6 @@ import (
 
 func main() {
 	plugin.Serve(&plugin.ServeOpts{
-		ProviderFunc: provider.Provider})
+		ProviderFunc: provider.Provider,
+	})
 }