Fix the terraform plan after running apply (#77)

* fix(job): set terraform state to empty in api return if default scheduling

* fix(job): adjustment in validation if the JOB is manual

Author: aristidesneto

internal/provider/resource_tsuru_job.go

@@ -234,7 +234,12 @@ func resourceTsuruJobRead(ctx context.Context, d *schema.ResourceData, meta inte
 	d.Set("team_owner", job.Job.TeamOwner)
 
 	d.Set("container", flattenJobContainer(job.Job.Spec.Container))
-	d.Set("schedule", job.Job.Spec.Schedule)
+
+	if job.Job.Spec.Manual {
+		d.Set("schedule", "")
+	} else {
+		d.Set("schedule", job.Job.Spec.Schedule)
+	}
 
 	if job.Job.Description != "" {
 		d.Set("description", job.Job.Description)

internal/provider/resource_tsuru_job_test.go

@@ -69,10 +69,32 @@ func TestAccResourceTsuruJobBasic(t *testing.T) {
 			return c.JSON(http.StatusOK, tsuru.JobInfo{Job: *job})
 		}
 
+		if iterationCount == 2 {
+			job := &tsuru.Job{
+				Name:        name,
+				Description: "my job description",
+				TeamOwner:   "my-team",
+				Plan:        tsuru.Plan{Name: "c1m1"},
+				Pool:        "prod",
+				Spec: tsuru.JobSpec{
+					Schedule: "",
+				},
+			}
+			return c.JSON(http.StatusOK, tsuru.JobInfo{Job: *job})
+		}
+
 		return c.JSON(http.StatusNotFound, nil)
 	})
 
 	fakeServer.PUT("/1.13/jobs/:name", func(c echo.Context) error {
+		job := tsuru.InputJob{}
+		c.Bind(&job)
+
+		assert.Equal(t, "job01", job.Name)
+		assert.Equal(t, "", job.Schedule)
+		assert.Equal(t, true, job.Manual)
+
+		iterationCount++
 		return c.JSON(http.StatusOK, nil)
 	})
 
@@ -106,6 +128,17 @@ func TestAccResourceTsuruJobBasic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "schedule", "* * * * *"),
 				),
 			},
+			{
+				Config: testAccResourceTsuruJobManual_basic(),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccResourceExists(resourceName),
+					resource.TestCheckResourceAttr(resourceName, "name", "job01"),
+					resource.TestCheckResourceAttr(resourceName, "description", "my job description"),
+					resource.TestCheckResourceAttr(resourceName, "plan", "c1m1"),
+					resource.TestCheckResourceAttr(resourceName, "team_owner", "my-team"),
+					resource.TestCheckResourceAttr(resourceName, "pool", "prod"),
+				),
+			},
 		},
 	})
 }
@@ -123,6 +156,18 @@ func testAccResourceTsuruJob_basic() string {
 `
 }
 
+func testAccResourceTsuruJobManual_basic() string {
+	return `
+	resource "tsuru_job" "job" {
+		name        = "job01"
+		description = "my job description"
+		plan        = "c1m1"
+		team_owner  = "my-team"
+		pool        = "prod"
+	}
+`
+}
+
 func TestAccResourceTsuruJobManual(t *testing.T) {
 	fakeServer := echo.New()