fix: cycles in regression program (#38)

fix: documentation for spatial programs

Author: tsutterley

README.rst

@@ -11,7 +11,7 @@ read-GRACE-harmonics
 .. |Language| image:: https://img.shields.io/badge/python-v3.7-green.svg
    :target: https://www.python.org/
 
-.. |License| image:: https://img.shields.io/badge/license-MIT-green.svg
+.. |License| image:: https://img.shields.io/github/license/tsutterley/read-grace-harmonics
    :target: https://github.com/tsutterley/read-GRACE-harmonics/blob/main/LICENSE
 
 .. |Documentation Status| image:: https://readthedocs.org/projects/read-grace-harmonics/badge/?version=latest

doc/source/user_guide/grace_spatial_error.rst

@@ -88,13 +88,15 @@ Command Line Options
     * ``'GSFC'``: use values from GSFC
     * ``'LARES'``: use filtered values from CSR
 - ``-U X``, ``--units X``: output units
+
     * ``1``: cm of water thickness
     * ``2``: mm of geoid height
     * ``3``: mm of elastic crustal deformation [Davis 2004]
     * ``4``: microGal gravitational perturbation
     * ``5``: mbar equivalent surface pressure
 - ``--spacing X``: spatial resolution of output data (dlon,dlat)
 - ``--interval X``: output grid interval
+
     * ``1``: (0:360, 90:-90)
     * ``2``: (degree spacing/2)
     * ``3``: non-global grid (set with defined bounds)

doc/source/user_guide/grace_spatial_maps.rst

@@ -103,13 +103,15 @@ Command Line Options
     * ``'GSFC'``: use values from GSFC
     * ``'LARES'``: use filtered values from CSR
 - ``-U X``, ``--units X``: output units
+
     * ``1``: cm of water thickness
     * ``2``: mm of geoid height
     * ``3``: mm of elastic crustal deformation [Davis 2004]
     * ``4``: microGal gravitational perturbation
     * ``5``: mbar equivalent surface pressure
 - ``--spacing X``: spatial resolution of output data (dlon,dlat)
 - ``--interval X``: output grid interval
+
     * ``1``: (0:360, 90:-90)
     * ``2``: (degree spacing/2)
     * ``3``: non-global grid (set with defined bounds)

doc/source/user_guide/regress_grace_maps.rst

@@ -28,13 +28,15 @@ Command Line Options
 - ``-R X``, ``--radius X``: Gaussian smoothing radius (km)
 - ``-d``, ``--destripe``: use decorrelation filter (destriping filter)
 - ``-U X``, ``--units X``: output units
+
     * ``1``: cm of water thickness
     * ``2``: mm of geoid height
     * ``3``: mm of elastic crustal deformation [Davis 2004]
     * ``4``: microGal gravitational perturbation
     * ``5``: mbar equivalent surface pressure
 - ``--spacing X``: spatial resolution of output data (dlon,dlat)
 - ``--interval X``: output grid interval
+
     * ``1``: (0:360, 90:-90)
     * ``2``: (degree spacing/2)
     * ``3``: non-global grid (set with defined bounds)
@@ -45,8 +47,8 @@ Command Line Options
      * ``'netCDF4'``
      * ``'HDF5'``
 - ``--redistribute-removed``: redistribute removed mass fields over the ocean
-- `--order X`: regression fit polynomial order
-- `--cycles X`: regression fit cyclical terms as wavelength in decimal years
+- ``--order X``: regression fit polynomial order
+- ``--cycles X``: regression fit cyclical terms as wavelength in decimal years
 - ``--log``: Output log file for job
 - ``-V``, ``--verbose``: verbose output of processing run
 - ``-M X``, ``--mode X``: Permissions mode of the files created

doc/source/user_guide/scale_grace_maps.rst

@@ -106,6 +106,7 @@ Command Line Options
     * ``'LARES'``: use filtered values from CSR
 - ``--spacing X``: spatial resolution of output data (dlon,dlat)
 - ``--interval X``: output grid interval
+
     * ``1``: (0:360, 90:-90)
     * ``2``: (degree spacing/2)
 - ``--mean-file X``: GRACE/GRACE-FO mean file to remove from the harmonic data

gravity_toolkit/utilities.py

@@ -510,6 +510,7 @@ def build_opener(username, password, context=ssl.SSLContext(),
     #-- All calls to urllib2.urlopen will now use handler
     #-- Make sure not to include the protocol in with the URL, or
     #-- HTTPPasswordMgrWithDefaultRealm will be confused.
+    return opener
 
 #-- PURPOSE: check that entered JPL PO.DAAC/ECCO Drive credentials are valid
 def check_credentials(HOST='https://podaac-tools.jpl.nasa.gov'):

scripts/regress_grace_maps.py

@@ -501,11 +501,11 @@ def main():
     #-- 0: mean
     #-- 1: trend
     #-- 2: acceleration
-    parser.add_argument('--order','-o',
+    parser.add_argument('--order',
         type=int, default=2,
         help='Regression fit polynomial order')
     #-- regression fit cyclical terms
-    parser.add_argument('--cycle','-c',
+    parser.add_argument('--cycles',
         type=float, default=[0.5,1.0,161.0/365.25], nargs='+',
         help='Regression fit cyclical terms')
     #-- Output log file for each job in forms