Useful methods that can be used in combination with Buffer.Slice().

[tunabay]

With the introduction of the Buffer.Slice() method, the expected usage of this package has changed. For example, it's more natural to replace .XxxAt() methods with .Slice().Xxx() combination.

Based on this change, it would be nice to add some useful methods that can be used in combination with the Buffer.Slice() method.

[tunabay]

Draft plan

Add:

• func (buf *Buffer) And(x *Buffer)
• func (buf *Buffer) Or(x *Buffer)
• func (buf *Buffer) Xor(x *Buffer)
• func (buf *Buffer) ToggleBits()

May deprecate:

• func (buf *Buffer) AndAt(off int, x BitArrayer) → .Slice().And()
• func (buf *Buffer) OrAt(off int, x BitArrayer) → .Slice().Or()
• func (buf *Buffer) XorAt(off int, x BitArrayer) → .Slice().Xor()
• func (buf *Buffer) ToggleBitsAt(off, nBits int) → .Slice().ToggleBits()
• func (buf *Buffer) BitArrayAt(off, nBits int) *BitArray → .Slice().BitArray()
• func (buf *Buffer) FillBitsAt(off, nBits int, bit byte) → .Slice().FillBits()

To be considered:

• And/Or/Xor arguments should be *Buffer type instead of BitArrayer type to minimize bit-shifts and copies. BitArrayer type arguments increase bit-shifting.
• But it is also better to be able to accept BitArrayer type.
• An option to branch processing by a type switch or type assertion. with concerns about performance.
• Another option is to have another methods like AndBitArray().