Skip to content

Added ability to toggle the Popover #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added ability to toggle the Popover #721

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70a83a1
Modified showHidePopover to toggle the popover if already visible. A…
mmacmillan Dec 4, 2014
6979545
Added rapid-click protection that could cause the popover to get stuc…
mmacmillan Dec 4, 2014
f3c11cb
Minor changes to satisfy jshint
mmacmillan Dec 4, 2014
a7dd7f0
Minor changes to satisfy jscs
mmacmillan Dec 4, 2014
c5fd255
Added a global accessor for the popover implementation, POPOVER, allo…
mmacmillan Dec 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions js/popovers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
'use strict';

var popover;
var listener;

var findPopovers = function (target) {
var i;
Expand All @@ -24,34 +25,36 @@
}
};

var hidePopover = function () {
popover.addEventListener('webkitTransitionEnd', (listener = onPopoverHidden));
popover.classList.remove('visible');
popover.parentNode.removeChild(backdrop);
};

var onPopoverHidden = function () {
popover.style.display = 'none';
popover.removeEventListener('webkitTransitionEnd', onPopoverHidden);
listener = popover.removeEventListener('webkitTransitionEnd', onPopoverHidden);
};

var backdrop = (function () {
var element = document.createElement('div');

element.classList.add('backdrop');

element.addEventListener('touchend', function () {
popover.addEventListener('webkitTransitionEnd', onPopoverHidden);
popover.classList.remove('visible');
popover.parentNode.removeChild(backdrop);
});
element.addEventListener('touchend', hidePopover);
element.addEventListener('click', hidePopover);

return element;
}());

var getPopover = function (e) {
var anchor = findPopovers(e.target);
var getPopover = function (e, id) {
var anchor = e && findPopovers(e.target);

if (!anchor || !anchor.hash || (anchor.hash.indexOf('/') > 0)) {
if ((!anchor || !anchor.hash || (anchor.hash.indexOf('/') > 0)) && !id) {
return;
}

try {
popover = document.querySelector(anchor.hash);
popover = document.querySelector(id || anchor.hash);
}
catch (error) {
popover = null;
Expand All @@ -68,13 +71,17 @@
return popover;
};

var showHidePopover = function (e) {
var popover = getPopover(e);
var showHidePopover = function (e, id) {
var popover = getPopover(e, id);

if (!popover) {
if (!popover || !!listener) {
return;
}

if (popover.classList.contains('visible')) {
return hidePopover();
}

popover.style.display = 'block';
popover.offsetHeight;
popover.classList.add('visible');
Expand All @@ -83,5 +90,13 @@
};

window.addEventListener('touchend', showHidePopover);

window.addEventListener('click', showHidePopover);
window.POPOVER = {
show: function (id) {
showHidePopover(null, id);
},
hide: function () {
popover && hidePopover();
}
};
}());