Skip to content

implement pedantic codec validations via minicbor context #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrruko wants to merge 11 commits into
base: main
Choose a base branch
from
+1,048 −30
Open

implement pedantic codec validations via minicbor context #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bdb3281
add some tests for cbor decoding
rrruko Aug 28, 2025
4198d79
add witness set decoder tests
rrruko Sep 9, 2025
a7e5547
add aux data tests
rrruko Sep 9, 2025
78adb47
use correct AuxiliaryData type
rrruko Sep 9, 2025
c5ba3cd
fix some tests
rrruko Sep 10, 2025
deecbc1
transaction body decoder tests
rrruko Sep 11, 2025
7a1a9a4
delete commented code
rrruko Sep 11, 2025
4f85d34
use is_some_and
rrruko Sep 15, 2025
8d2fbe2
make multiasset wrapper transparent to fix pallas-traverse build
rrruko Sep 15, 2025
937f2cf
implement pedantic validations as minicbor context
rrruko Oct 13, 2025
11de009
implement generic Strict/StrictVerbose wrappers
rrruko Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions pallas-codec/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,9 +858,9 @@ where

let inner: Vec<T> = d.decode_with(ctx)?;

// if inner.is_empty() {
// return Err(Error::message("decoding empty set as NonEmptySet"));
// }
if inner.is_empty() {
return Err(Error::message("decoding empty set as NonEmptySet"));
}

Ok(Self(inner))
}
Expand Down Expand Up @@ -998,7 +998,7 @@ impl From<&AnyUInt> for u64 {
/// Introduced in Conway
/// positive_coin = 1 .. 18446744073709551615
#[derive(
Encode, Decode, Debug, PartialEq, Copy, Clone, PartialOrd, Eq, Ord, Hash, Serialize, Deserialize,
Encode, Debug, PartialEq, Copy, Clone, PartialOrd, Eq, Ord, Hash, Serialize, Deserialize,
)]
#[serde(transparent)]
#[cbor(transparent)]
Expand All @@ -1016,6 +1016,17 @@ impl TryFrom<u64> for PositiveCoin {
}
}

impl<'b, C> minicbor::Decode<'b, C> for PositiveCoin {
fn decode(d: &mut minicbor::Decoder<'b>, ctx: &mut C) -> Result<Self, minicbor::decode::Error> {
let n = d.decode_with(ctx)?;
if n == 0 {
return Err(minicbor::decode::Error::message("PositiveCoin must not be 0"));
}
Ok(PositiveCoin(n))
}
}


impl From<PositiveCoin> for u64 {
fn from(value: PositiveCoin) -> Self {
value.0
Expand Down
Loading