Merge pull request #254 from tharropoulos/union-pagination

fix: add missing page parameter for union search pagination

Author: jasonbosco

src/SearchRequestAdapter.js

@@ -491,6 +491,7 @@ export class SearchRequestAdapter {
     // Add union parameter if configured
     if (this.configuration.union) {
       searchRequest.union = this.configuration.union;
+      commonParams.page = searches[0].page;
     }
 
     return this.typesenseClient.multiSearch.perform(searchRequest, commonParams);

test/SearchRequestAdpater.test.js

@@ -332,7 +332,9 @@ describe("SearchRequestAdapter", () => {
               },
             ],
           },
-          {},
+          {
+            page: 1,
+          },
         );
       });
 
@@ -466,6 +468,7 @@ describe("SearchRequestAdapter", () => {
             conversation: true,
             conversation_id: "conv_123",
             conversation_model_id: "model_456",
+            page: 1,
           },
         );
       });
@@ -507,7 +510,9 @@ describe("SearchRequestAdapter", () => {
               },
             ],
           },
-          {},
+          {
+            page: 1,
+          },
         );
       });
     });

test/unionSearch.test.js

@@ -58,4 +58,37 @@ describe("Union Search", () => {
       });
     });
   });
+
+  describe("pagination with union search", () => {
+    beforeEach(async () => {
+      return expect(page).toFill("#searchbox input[type=search]", "phone");
+    });
+
+    it("renders pagination controls for merged results from multiple indices", async () => {
+      await page.waitForSelector("#pagination a.ais-Pagination-link");
+
+      const paginationLinks = await page.$$("#pagination a.ais-Pagination-link");
+      expect(paginationLinks.length).toBeGreaterThan(0);
+
+      await expect(page).toMatchElement("#hits .ais-Hits-item:nth-of-type(1)");
+    });
+
+    it("shows different merged results when navigating to the second page", async () => {
+      await page.waitForSelector("#pagination a.ais-Pagination-link");
+
+      const firstPageFirstResult = await page.$eval("#hits .ais-Hits-item:nth-of-type(1)", (el) => el.textContent);
+
+      await expect(page).toClick("#pagination a", { text: "2" });
+
+      await page.waitForSelector("#hits .ais-Hits-item:nth-of-type(1)");
+
+      const secondPageFirstResult = await page.$eval("#hits .ais-Hits-item:nth-of-type(1)", (el) => el.textContent);
+
+      expect(firstPageFirstResult).not.toBe(secondPageFirstResult);
+
+      await expect(page).toMatchElement("#hits");
+      await expect(page).not.toMatchElement("#product-hits", { timeout: 1000 });
+      await expect(page).not.toMatchElement("#brand-hits", { timeout: 1000 });
+    });
+  });
 });