Fix issue with adding/removing type use annotations on array component type. #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrieve
pushed a commit
to agrieve/NullAwayAnnotator
that referenced
this pull request
Apr 3, 2025
…t type (ucr-riple#268) With the new specification for @nullable type-use annotations, the correct placement for annotating the component type of an array is as follows: ```java @nullable Object arr[] ``` However, when parsing this expression, Javaparser associates the annotation with the entire `Object[] arr` node rather than the intended component type `@Nullable Object`. This PR addresses this issue by adding a workaround ensuring correct annotation placement and includes a comprehensive set of tests to validate the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new specification for @nullable type-use annotations, the correct placement for annotating the component type of an array is as follows:
However, when parsing this expression, Javaparser associates the annotation with the entire
Object[] arrnode rather than the intended component type@Nullable Object.This PR addresses this issue by adding a workaround ensuring correct annotation placement and includes a comprehensive set of tests to validate the fix.