Skip to content

Conversation

@illiyyin
Copy link

Hi guys, this is my first open-source contribution pr, let me know what should I do

I tried to use tiptap in my small project using nuxt, after I followed the current instruction. Looks like the code is still using nuxt 2, and I'm using nuxt 3 so I got an error, and then it looks like the code needs to be updated

I don't find the solve on the issue, but I found these issues on the tiptap main repo

After I tried to debug, my code working.

This pr still needs to be updated tho, since this part here is using embed. I can't find the code on this repo
image

@vercel
Copy link

vercel bot commented Mar 30, 2025

@illiyyin is attempting to deploy a commit to the Tiptap Team on Vercel.

A member of the Team first needs to authorize it.

@arnaugomez
Copy link
Contributor

Thanks for your contribution! It's a great improvement for Nuxt 3 devs, but it overrides the Nuxt 2 guide. So there would be no installation guide for Nuxt 2 developers. Am I right? Or does your guide work for Nuxt 2, too?

In my opinion, I would either:

A. Create different pages, each with a guide for nuxt 2 and nuxt 3 respectively.

B. Mention, in the Nuxt guide, the differences in setup between Nuxt 2 and Nuxt 3. So that Nuxt 2 devs can still set up Tiptap.

@bdbch what do you think is the best option?

@bdbch
Copy link
Member

bdbch commented Jul 9, 2025

I would make it dependend on whether Nuxt 2 is not supported anymore or people still actively use Nuxt 2.

If it's the latter than I'd go with two separate pages, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants