Augment measurement data for root access in Superset #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request augments measurement data by adding additional fields to the Prisma schema and updating the corresponding measurement service to extract and map new measurement details.
- Extended the measurements model with extra fields for elapsed time, connection properties, client location, and ASN information.
- Updated the measurement service to extract additional data from the request DTO for the new fields.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/prisma/schema.prisma | Added new optional fields to the measurements model. |
| src/measurement/measurement.service.ts | Implemented extraction and mapping of new fields from the DTO. |
To get access to this data on root from superset
Victor1Ja
force-pushed
the
feat/augmentData
branch
from
a6f313a to
973e289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.