Merge pull request #534 from unit-finance/UD-13980-repayment-filters-and-chore-path

UD-13980 repayment filters and simulations path

Author: ilyamerman

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@unit-finance/unit-node-sdk",
-  "version": "1.3.7",
+  "version": "1.3.8",
   "description": "",
   "main": "dist/unit.js",
   "types": "dist/unit.d.ts",

package.json

@@ -21,7 +21,9 @@ export class Repayments extends BaseResource {
             "page[offset]": (params?.offset ? params.offset : 0),
             ...(params?.accountId && { "filter[accountId]": params.accountId }),
             ...(params?.creditAccountId && { "filter[creditAccountId]": params.creditAccountId }),
-            ...(params?.customerId && { "filter[customerId]": params.customerId })
+            ...(params?.customerId && { "filter[customerId]": params.customerId }),
+            ...(params?.since && { "filter[since]": params.since }),
+            ...(params?.until && { "filter[until]": params.until }),
         }
 
         if (params?.type)
@@ -71,4 +73,14 @@ export interface RepaymentListParams extends BaseListParams {
      * Optional. Filters the result according to the associated [Recurring Repayment](https://www.unit.co/docs/api/recurring-repayments/) id
      */
     recurringRepayment?: string
+
+    /**
+     * Optional. Filters Repayments that occurred after the specified date. Usage example: filter[since]=2020-01-13T16:01:19.346Z.
+     */
+    since?: string
+
+    /**
+     * Optional. Filters Repayments that occurred before the specified date. Usage example: filter[until]=2020-01-13T16:01:19.346Z.
+     */
+    until?: string
 }

resources/repayments.ts

@@ -162,7 +162,7 @@ export class Simulations extends BaseResource {
         request: CreateCardTransactionAuthorizationRequestSimulation
     ): Promise<UnitResponse<CardTransactionAuthorizationRequest>> {
         return this.httpPost<UnitResponse<CardTransactionAuthorizationRequest>>(
-            "authorization-requests/card-transaction",
+            "/authorization-requests/card-transaction",
             {
                 data: request
             }
@@ -173,7 +173,7 @@ export class Simulations extends BaseResource {
         request: CreateCardPurchaseAuthorizationRequestSimulation
     ): Promise<UnitResponse<PurchaseAuthorizationRequest>> {
         return this.httpPost<UnitResponse<PurchaseAuthorizationRequest>>(
-            "authorization-requests/purchase",
+            "/authorization-requests/purchase",
             {
                 data: request
             }
@@ -184,7 +184,7 @@ export class Simulations extends BaseResource {
         request: CreateAtmAuthorizationRequestSimulation
     ): Promise<UnitResponse<AtmAuthorizationRequest>> {
         return this.httpPost<UnitResponse<AtmAuthorizationRequest>>(
-            "authorization-requests/atm",
+            "/authorization-requests/atm",
             {
                 data: request
             }

resources/simulations.ts

@@ -9,7 +9,7 @@ describe("Transactions List", () => {
     test("Get Transactions List", async () => {
         const res = await unit.transactions.list()
         res.data.forEach(element => {
-            expect(element.type).toContain("Transaction")
+            expect(element.type === "interestCharge" || element.type.includes("Transaction")).toBe(true)
             transactionsId.push({ accountId: element.relationships.account.data.id, transactionId: element.id })
         })
     })
@@ -19,7 +19,7 @@ describe("Get Transaction Test", () => {
     test("get each transaction", async () => {
         transactionsId.forEach(async element => {
             const transaction = (await unit.transactions.get(element.accountId, element.transactionId)).data
-            expect(transaction.type).toContain("Transaction")
+            expect(transaction.type === "interestCharge" || transaction.type.includes("Transaction")).toBe(true)
         })
     })
 })
@@ -28,7 +28,7 @@ describe("Update Transaction Test", () => {
     test("update each transaction", async () => {
         transactionsId.forEach(async element => {
             const transaction = (await unit.transactions.get(element.accountId, element.transactionId)).data
-            expect(transaction.type).toContain("Transaction")
+            expect(transaction.type === "interestCharge" || transaction.type.includes("Transaction")).toBe(true)
             const response = (await unit.transactions.update({
                 accountId: transaction.relationships.account.data.id, 
                 transactionId: transaction.id,

tests/transactions.spec.ts

@@ -1,7 +1,7 @@
 import { Address, CardNetwork, Coordinates, Counterparty, CurrencyConversion, Direction, Merchant, Relationship, RelationshipsArray, RichMerchantData, Tags, UnimplementedFields } from "./common"
 
 export type Transaction = OriginatedAchTransaction | ReceivedAchTransaction | ReturnedAchTransaction | ReturnedReceivedAchTransaction | DishonoredAchTransaction | BookTransaction | PurchaseTransaction | AtmTransaction | FeeTransaction | FeeReversalTransaction |
-    CardReversalTransaction | CardTransaction | WireTransaction | ReturnedWireTransaction | ReleaseTransaction | AdjustmentTransaction | InterestTransaction | DisputeTransaction | CheckDepositTransaction | CheckPaymentTransaction | ReturnedCheckDepositTransaction | ReturnedCheckPaymentTransaction | PaymentAdvanceTransaction |
+    CardReversalTransaction | CardTransaction | WireTransaction | ReturnedWireTransaction | ReleaseTransaction | AdjustmentTransaction | InterestTransaction | InterestChargeTransaction | DisputeTransaction | CheckDepositTransaction | CheckPaymentTransaction | ReturnedCheckDepositTransaction | ReturnedCheckPaymentTransaction | PaymentAdvanceTransaction |
     RepaidPaymentAdvanceTransaction | PaymentCanceledTransaction | RewardTransaction | NegativeBalanceCoverageTransaction | PushToCardTransaction | AccountLowBalanceClosureTransaction | BankRepaymentTransaction
 
 export interface BaseTransaction {
@@ -770,6 +770,13 @@ export type InterestTransaction = BaseTransaction & {
     type: "interestTransaction"
 }
 
+export type InterestChargeTransaction = BaseTransaction & {
+    /**
+     * Type of the transaction resource. The value is always interestCharge.
+     */
+    type: "interestCharge"
+}
+
 export type DisputeTransaction = BaseTransaction & {
     /**
      * Type of the transaction resource. The value is always disputeTransaction.