Skip to content

Commit 1536f02

Browse files
authored
Merge pull request #38 from universal-tool-calling-protocol/dev
Add contributor and modify contributing.md
2 parents c8cccc4 + 4bfd495 commit 1536f02

File tree

2 files changed

+3
-27
lines changed

2 files changed

+3
-27
lines changed

about/about-us.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ We believe in the power of open source collaboration. This project thrives on co
3434
- Luca Perrozzi ([LinkedIn](https://www.linkedin.com/in/luca-perrozzi/))
3535
- Roberto Catalano ([LinkedIn](https://www.linkedin.com/in/roberto-catalano-5b7793123/), [GitHub](https://github.com/Robobc))
3636
- Tiago Prelato ([LinkedIn](https://www.linkedin.com/in/tiago-prelato-257787210/), [X](https://x.com/SneyX_))
37+
- Bruce Miao
3738

3839
## Join Us
3940

about/contributing.md

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -170,21 +170,13 @@ class DatabaseToolRepository(ToolRepository):
170170

171171
### Test Coverage for Source Code Changes
172172

173-
**All PRs that modify source code in the library must include appropriate tests:**
174-
175-
- **Unit Tests**: Test individual components in isolation
176-
- **Integration Tests**: Test component interactions
177-
- **Contract Tests**: Verify interface implementations
178-
- **End-to-End Tests**: Test complete workflows
173+
**All PRs that modify source code in the library must include appropriate tests**
179174

180175
### Test Structure
181176

182177
```
183178
tests/
184-
├── unit/ # Fast, isolated tests
185-
├── integration/ # Component interaction tests
186-
├── e2e/ # End-to-end workflow tests
187-
└── fixtures/ # Test data and mocks
179+
├── ...
188180
```
189181

190182
### Test Quality Standards
@@ -194,23 +186,6 @@ tests/
194186
- **Speed**: Unit tests should run in milliseconds
195187
- **Clarity**: Test names should describe the scenario being tested
196188

197-
```python
198-
# Good test structure
199-
class TestToolInvoker:
200-
def test_invoke_with_valid_params_returns_success_response(self):
201-
# Arrange
202-
mock_client = Mock(spec=HttpClient)
203-
mock_client.post.return_value = {"status": "success"}
204-
invoker = ToolInvoker(mock_client)
205-
206-
# Act
207-
result = invoker.invoke(sample_tool, {"param": "value"})
208-
209-
# Assert
210-
assert result["status"] == "success"
211-
mock_client.post.assert_called_once()
212-
```
213-
214189
## Code Quality Standards
215190

216191
### Code Style

0 commit comments

Comments
 (0)