PHP 8 4 support (ecotoneframework#477)

* feat: PHP 8.4

* handle ecotone deprecations

* localstack and aws sdk

* clean up

* Fixes

Author: dgafka

.github/workflows/benchmark-pr.yml

@@ -54,7 +54,7 @@ jobs:
         ports:
           - 5432:5432
       localstack:
-        image: localstack/localstack:2.2.0
+        image: localstack/localstack:3.0.0
         env:
           SERVICES: 'sqs,sns'
         ports:

.github/workflows/quickstart-examples.yml

@@ -19,7 +19,7 @@ jobs:
           - name: 'Quickstart'
             package: 'ecotone/quickstart-examples'
             directory: 'quickstart-examples'
-        php-versions: [ '8.3' ]
+        php-versions: [ '8.4' ]
         stability: [prefer-stable]
 
     services:
@@ -76,7 +76,7 @@ jobs:
         ports:
           - 5432:5432
       localstack:
-        image: localstack/localstack:2.2.0
+        image: localstack/localstack:3.0.0
         env:
           SERVICES: 'sqs,sns'
         ports:

.github/workflows/split-testing.yml

@@ -40,7 +40,7 @@ jobs:
       fail-fast: true
       matrix:
         package: ${{ fromJson(needs.get_packages.outputs.matrix) }}
-        php-versions: [ '8.1', '8.3' ]
+        php-versions: [ '8.1', '8.4' ]
         stability: [prefer-stable, prefer-lowest]
 
     services:
@@ -97,7 +97,7 @@ jobs:
         ports:
           - 5432:5432
       localstack:
-        image: localstack/localstack:2.2.0
+        image: localstack/localstack:3.0.0
         env:
           SERVICES: 'sqs,sns'
         ports:

.github/workflows/test-monorepo.yml

@@ -16,7 +16,7 @@ jobs:
       fail-fast: true # Fail the entire workflow if any job fails
       matrix:
         operating-system: [ ubuntu-latest ]
-        php-versions: [ '8.3' ]
+        php-versions: [ '8.4' ]
         stability: [prefer-stable]
     services:
       kafka:
@@ -72,7 +72,7 @@ jobs:
         ports:
           - 5432:5432
       localstack:
-        image: localstack/localstack:2.2.0
+        image: localstack/localstack:3.0.0
         env:
           SERVICES: 'sqs,sns'
         ports:

composer.json

@@ -152,7 +152,7 @@
         "predis/predis": "^1.1.10",
         "symfony/expression-language": "^6.0|^7.0",
         "symplify/monorepo-builder": "11.1.21",
-        "aws/aws-sdk-php": "<=3.269.5",
+        "aws/aws-sdk-php": ">=3.340.5",
         "symfony/messenger": "^5.4|^6.0|^7.0",
         "symfony/amqp-messenger": "^5.4.31|^6.0|^7.0",
         "symfony/doctrine-messenger": "^5.4|^6.0|^7.0",

docker-compose.yml

@@ -2,7 +2,7 @@ version: "3.8"
 
 services:
   app:
-    image: simplycodedsoftware/php:8.3.10
+    image: simplycodedsoftware/php:8.4.6
     volumes:
       - "$PWD:/data/app"
     working_dir: "/data/app"
@@ -84,7 +84,7 @@ services:
       - "15672:15672"
       - "5672:5672"
   localstack:
-    image: localstack/localstack:2.2.0
+    image: localstack/localstack:3.0.0
     environment:
       LOCALSTACK_HOST: 'localstack'
       SERVICES: 'sqs,sns'

packages/Dbal/src/EnqueueDbal/DbalConnectionFactory.php

@@ -131,7 +131,7 @@ private function establishConnection(): Connection
         return $this->connection;
     }
 
-    private function parseDsn(string $dsn, array $config = null): array
+    private function parseDsn(string $dsn, ?array $config = null): array
     {
         $parsedDsn = Dsn::parseFirst($dsn);
 

packages/Dbal/src/EnqueueDbal/DbalMessage.php

@@ -148,7 +148,7 @@ public function setRedelivered(bool $redelivered): void
         $this->redelivered = $redelivered;
     }
 
-    public function setReplyTo(string $replyTo = null): void
+    public function setReplyTo(?string $replyTo = null): void
     {
         $this->setHeader('reply_to', $replyTo);
     }
@@ -163,7 +163,7 @@ public function getPriority(): ?int
         return $this->priority;
     }
 
-    public function setPriority(int $priority = null): void
+    public function setPriority(?int $priority = null): void
     {
         $this->priority = $priority;
     }
@@ -176,7 +176,7 @@ public function getDeliveryDelay(): ?int
     /**
      * Set delay in milliseconds.
      */
-    public function setDeliveryDelay(int $deliveryDelay = null): void
+    public function setDeliveryDelay(?int $deliveryDelay = null): void
     {
         $this->deliveryDelay = $deliveryDelay;
     }
@@ -192,12 +192,12 @@ public function getTimeToLive(): ?int
     /**
      * Set time to live in milliseconds.
      */
-    public function setTimeToLive(int $timeToLive = null): void
+    public function setTimeToLive(?int $timeToLive = null): void
     {
         $this->timeToLive = $timeToLive;
     }
 
-    public function setCorrelationId(string $correlationId = null): void
+    public function setCorrelationId(?string $correlationId = null): void
     {
         $this->setHeader('correlation_id', $correlationId);
     }
@@ -207,7 +207,7 @@ public function getCorrelationId(): ?string
         return $this->getHeader('correlation_id', null);
     }
 
-    public function setMessageId(string $messageId = null): void
+    public function setMessageId(?string $messageId = null): void
     {
         $this->setHeader('message_id', $messageId);
     }
@@ -224,7 +224,7 @@ public function getTimestamp(): ?int
         return null === $value ? null : $value;
     }
 
-    public function setTimestamp(int $timestamp = null): void
+    public function setTimestamp(?int $timestamp = null): void
     {
         $this->setHeader('timestamp', $timestamp);
     }
@@ -244,7 +244,7 @@ public function getRedeliverAfter(): int
         return $this->redeliverAfter;
     }
 
-    public function setRedeliverAfter(int $redeliverAfter = null): void
+    public function setRedeliverAfter(?int $redeliverAfter = null): void
     {
         $this->redeliverAfter = $redeliverAfter;
     }
@@ -254,7 +254,7 @@ public function getPublishedAt(): ?int
         return $this->publishedAt;
     }
 
-    public function setPublishedAt(int $publishedAt = null): void
+    public function setPublishedAt(?int $publishedAt = null): void
     {
         $this->publishedAt = $publishedAt;
     }

packages/Dbal/src/EnqueueDbal/DbalProducer.php

@@ -132,7 +132,7 @@ public function send(Destination $destination, Message $message): void
         }
     }
 
-    public function setDeliveryDelay(int $deliveryDelay = null): Producer
+    public function setDeliveryDelay(?int $deliveryDelay = null): Producer
     {
         $this->deliveryDelay = $deliveryDelay;
 
@@ -144,7 +144,7 @@ public function getDeliveryDelay(): ?int
         return $this->deliveryDelay;
     }
 
-    public function setPriority(int $priority = null): Producer
+    public function setPriority(?int $priority = null): Producer
     {
         $this->priority = $priority;
 
@@ -156,7 +156,7 @@ public function getPriority(): ?int
         return $this->priority;
     }
 
-    public function setTimeToLive(int $timeToLive = null): Producer
+    public function setTimeToLive(?int $timeToLive = null): Producer
     {
         $this->timeToLive = $timeToLive;
 

packages/Dbal/tests/Integration/Recoverability/DbalDeadLetterTest.php

@@ -50,7 +50,7 @@ public function test_storing_wrapped_error_message()
         );
     }
 
-    private function createFailedMessage(Message $message, Throwable $exception = null): Message
+    private function createFailedMessage(Message $message, ?Throwable $exception = null): Message
     {
         return ErrorMessage::create(MessageHandlingException::fromOtherException($exception ?? new MessageHandlingException(), $message));
     }