chore: Update pull_request_template.md to add more docs in PR Checklist #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
approved these changes
Oct 24, 2023
Contributor
|
im getting mixed feelings for all these checks... the sheer numbe is getting a bit out of hand... |
Contributor
Author
Hum you are not wrong, that is starting to be a lot, but also it is very easy to forget some docs. Hum let me rethink that |
Contributor
|
maybe just a single bullet point to remind them to update the relevant docs, and links the major folders ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
chore: Update pull_request_template.md to add docs in PR Checklist