Skip to content

Commit e4439ed

Browse files
authored
Merge pull request #2817 from unoplatform/mergify/bp/release/stable/6.0/pr-2816
2 parents 8bd2ab7 + 9c7243b commit e4439ed

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

src/Directory.Build.props

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,13 +173,18 @@
173173

174174
<Target Name="__RemoveUnoRuntimeWasm"
175175
AfterTargets="UnoImplicitPackages">
176+
<ItemGroup Condition="'$(IsUnoHead)' != 'true' AND $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'browserwasm'">
176177
<!--
177178
Disable explicit references to Uno.WinUI.Runtime.WebAssembly in order to avoid using JSInvoke directly
178179
This change is done manually here to avoid
179180
-->
180-
<ItemGroup>
181-
<PackageReference Remove="Uno.WinUI.Runtime.WebAssembly"
182-
Condition="'$(IsUnoHead)' != 'true' AND $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'browserwasm'" />
181+
<PackageReference Remove="Uno.WinUI.Runtime.WebAssembly" />
182+
183+
<!--
184+
We also remove the Uno.WinUI.WebAssembly package reference, as it is not needed in this case and will break the skia renderer
185+
https://github.com/unoplatform/uno/issues/20792
186+
-->
187+
<PackageReference Remove="Uno.WinUI.WebAssembly" />
183188
</ItemGroup>
184189
</Target>
185190

src/Uno.Extensions.Authentication.MSAL/MsalAuthenticationProvider.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,8 @@
44
using Uno.Extensions.Logging;
55
using LogLevel = Microsoft.Extensions.Logging.LogLevel;
66
#if UNO_EXT_MSAL
7-
#if BROWSERWASM1_0_OR_GREATER
8-
using MsalCacheHelper = Microsoft.Identity.Client.Extensions.Msal.Wasm.MsalCacheHelper;
9-
#else
107
using MsalCacheHelper = Microsoft.Identity.Client.Extensions.Msal.MsalCacheHelper;
118
#endif
12-
#endif
139

1410
namespace Uno.Extensions.Authentication.MSAL;
1511

@@ -193,11 +189,7 @@ private async Task SetupStorage()
193189
var builder = new StorageCreationPropertiesBuilder(CacheFileName, folderPath);
194190
Settings?.Store?.Invoke(builder);
195191
var storage = builder.Build();
196-
#if BROWSERWASM1_0_OR_GREATER
197-
var cacheHelper = await MsalCacheHelper.CreateAsync(Logger, storage);
198-
#else
199192
var cacheHelper = await MsalCacheHelper.CreateAsync(storage);
200-
#endif
201193
cacheHelper.RegisterCache(_pca!.UserTokenCache);
202194
if (Logger.IsEnabled(LogLevel.Trace))
203195
{

0 commit comments

Comments
 (0)