Final cleaning up.

yufei4hua · yufei4hua · commit c0c4c969b933 · 2025-11-21T09:55:05.000+01:00
diff --git a/crazyflow/sim/visualize.py b/crazyflow/sim/visualize.py
@@ -91,7 +91,6 @@ def change_material(
         raise ValueError(f"drone_ids must be in range [0, {sim.n_drones - 1}], got {drone_ids}")
 
     if rgba is not None:
-        # this returns itself if rgba is already the right shape
         rgba = np.broadcast_to(rgba, (len(drone_ids), 4))
 
     if emission is not None:
@@ -107,7 +106,7 @@ def change_material(
         mat_ids.append(mat_id)
 
     if rgba is not None:
-        mj_model.mat_rgba[mat_ids, :] = rgba
+        mj_model.mat_rgba[mat_ids] = rgba
 
     if emission is not None:
         mj_model.mat_emission[mat_ids] = emission
diff --git a/tests/unit/test_sim.py b/tests/unit/test_sim.py
@@ -538,7 +538,7 @@ def test_change_material_errors(device: str):
             sim, mat_name="bad_mat", drone_ids=drone_ids, rgba=rgba, emission=emission
         )
 
-    with pytest.raises(ValueError, match=r"drone_ids must be 1D array"):
+    with pytest.raises(ValueError, match="drone_ids must be 1D array"):
         change_material(
             sim,
             mat_name="led_top",

Original file line number	Diff line number	Diff line change
`@@ -538,7 +538,7 @@ def test_change_material_errors(device: str):`
`538`	`538`	`sim, mat_name="bad_mat", drone_ids=drone_ids, rgba=rgba, emission=emission`
`539`	`539`	`)`
`540`	`540`
`541`		`- with pytest.raises(ValueError, match=r"drone_ids must be 1D array"):`
	`541`	`+ with pytest.raises(ValueError, match="drone_ids must be 1D array"):`
`542`	`542`	`change_material(`
`543`	`543`	`sim,`
`544`	`544`	`mat_name="led_top",`