chore: move interop workflow to daily common

Author: gmelodie

.github/workflows/daily_common.yml

@@ -95,3 +95,22 @@ jobs:
 
           export NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }}"
           nimble testintegration
+
+      - name: Run interop hole punching test
+        runs-on: ubuntu-22.04
+        steps:
+          - uses: actions/checkout@v4
+          - uses: docker/setup-buildx-action@v3
+          - name: Build image
+            run: docker buildx build --load -t nim-libp2p-head -f interop/hole-punching/Dockerfile .
+          - name: Run tests
+            uses: libp2p/test-plans/.github/actions/run-interop-hole-punch-test@master
+            with:
+              test-filter: nim-libp2p-head
+              test-ignore: rust # rust v0.53 fails for some reason unrelated to us
+              extra-versions: ${{ github.workspace }}/interop/hole-punching/version.json
+              s3-cache-bucket: ${{ vars.S3_LIBP2P_BUILD_CACHE_BUCKET_NAME }}
+              s3-access-key-id: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_ACCESS_KEY_ID }}
+              s3-secret-access-key: ${{ secrets.S3_LIBP2P_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}
+              aws-region: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_REGION }}
+

.github/workflows/interop.yml

@@ -41,25 +41,6 @@ jobs:
           s3-secret-access-key: ${{ secrets.S3_LIBP2P_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}
           aws-region: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_REGION }}
 
-  # run-hole-punching-interop:
-  #   name: Run hole-punching interoperability tests
-  #   runs-on: ubuntu-22.04
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: docker/setup-buildx-action@v3
-  #     - name: Build image
-  #       run: docker buildx build --load -t nim-libp2p-head -f interop/hole-punching/Dockerfile .
-  #     - name: Run tests
-  #       uses: libp2p/test-plans/.github/actions/run-interop-hole-punch-test@master
-  #       with:
-  #         test-filter: nim-libp2p-head
-  #         test-ignore: rust # rust v0.53 fails for some reason unrelated to us
-  #         extra-versions: ${{ github.workspace }}/interop/hole-punching/version.json
-  #         s3-cache-bucket: ${{ vars.S3_LIBP2P_BUILD_CACHE_BUCKET_NAME }}
-  #         s3-access-key-id: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_ACCESS_KEY_ID }}
-  #         s3-secret-access-key: ${{ secrets.S3_LIBP2P_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}
-  #         aws-region: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_REGION }}
-
   run-autonatv2-interop:
     name: Run AutoNATv2 interoperability tests
     runs-on: ubuntu-22.04