Use approval tests for result image rendering

* Add approval tests
* Make TODOs into a bug (#49)

Author: MaybeJustJames

.github/workflows/server-pr.yaml

@@ -92,7 +92,7 @@ jobs:
       - name: Run tests
         run: |
           source .venv/bin/activate
-          coverage run -m pytest
+          coverage run -m pytest -rxXs --approvaltests-use-reporter='PythonNativeReporter'
           coverage report
         working-directory: ${{ env.working-directory }}
 

server/poetry.lock

@@ -27,6 +27,8 @@ itsdangerous = "^2.2.0"
 asgi-csrf = "^0.11"
 apscheduler = "^3.11.0"
 httpx = "^0.28.1"
+approvaltests = "^15.1.0"
+pytest-approvaltests = "^0.2.4"
 
 [tool.poetry.group.dev.dependencies]
 mypy = "^1.5.1"

server/pyproject.toml

@@ -1,6 +1,7 @@
 """Shared pytest fixtures."""
 
 import json
+import logging
 import os
 from pathlib import Path
 
@@ -10,10 +11,12 @@
 from sqlalchemy.orm import Session, sessionmaker
 from testcontainers.postgres import PostgresContainer
 
-from ttfd import abomination, crud
+from ttfd import abomination, crud, reactions
 from ttfd.deps import get_db
 from ttfd.main import app
-from ttfd.models import Base
+from ttfd.models import Base, Reaction
+
+logger = logging.getLogger(__name__)
 
 
 @pytest.fixture(scope="session")
@@ -35,6 +38,7 @@ def database(setup_postgres):
     # 2. Find all metabolites referenced by those and add dummies
     metabolites = json.loads(Path("test/metabolites-test-generated.json").read_text())
     paths = json.loads(Path("test/paths-test-generated.json").read_text())
+    reactions = json.loads(Path("test/reactions-test-generated.json").read_text())
     # 3.
     session_factory = sessionmaker(
         bind=engine,
@@ -60,6 +64,19 @@ def database(setup_postgres):
                 categories=[],
             )
 
+        for reaction, instances in reactions.items():
+            for num, instance in enumerate(instances):
+                crud.insert_reaction(
+                    session,
+                    reaction,
+                    None,
+                    num,
+                    None,
+                    [],
+                    instance["left"],
+                    instance["right"],
+                )
+
         for path in paths:
             rp, met, br, lo, p = path.split("\n")
             lp = abomination.LabelingPath(
@@ -125,6 +142,7 @@ def regression_database(setup_postgres):
 @pytest.fixture
 def test_client(database: Session):
     """Provide a http client to access the app in a test environment."""
+
     def get_db_override():
         return database