Dont call Connect-Yubikey when calculating paramaters for Connect-YubiKeyFIDO2 (#175)

virot · web-flow · commit b9f929c98859 · 2025-07-24T16:43:57.000+02:00
Dont call Connect-Yubikey when calculating parameters for Connect-YubiKeyFIDO2
diff --git a/Module/Cmdlets/FIDO2/ConnectYubikeyFIDO2.cs b/Module/Cmdlets/FIDO2/ConnectYubikeyFIDO2.cs
@@ -34,7 +34,8 @@ public class ConnectYubikeyFIDO2Command : PSCmdlet, IDynamicParameters
         // Get dynamic parameters based on YubiKey state
         public object GetDynamicParameters()
         {
-            try { YubiKeyModule.ConnectYubikey(); } catch { }
+            // Block this out so that Cmdlet tab completion does not call Connect-Yubikey
+            // try { YubiKeyModule.ConnectYubikey(); } catch { }
 
             Collection<Attribute> PIN;
             if (YubiKeyModule._yubikey is not null)

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ public class ConnectYubikeyFIDO2Command : PSCmdlet, IDynamicParameters`
`34`	`34`	`// Get dynamic parameters based on YubiKey state`
`35`	`35`	`public object GetDynamicParameters()`
`36`	`36`	`{`
`37`		`- try { YubiKeyModule.ConnectYubikey(); } catch { }`
	`37`	`+ // Block this out so that Cmdlet tab completion does not call Connect-Yubikey`
	`38`	`+ // try { YubiKeyModule.ConnectYubikey(); } catch { }`
`38`	`39`
`39`	`40`	`Collection<Attribute> PIN;`
`40`	`41`	`if (YubiKeyModule._yubikey is not null)`