Allow separate group owner for log directory

Currently the group for `log_dir` is set to the `service_group`. It can
be useful to set a different group, eg the `adm` group is often used to
allow read access to logs.

Setting `log_dir_group` with a suitable `log_dir_mode` would facilitate
this.

Author: sagepe

REFERENCE.md

@@ -115,6 +115,7 @@ The following parameters are available in the `redis` class:
 * [`list_max_ziplist_entries`](#-redis--list_max_ziplist_entries)
 * [`list_max_ziplist_value`](#-redis--list_max_ziplist_value)
 * [`log_dir`](#-redis--log_dir)
+* [`log_dir_group`](#-redis--log_dir_group)
 * [`log_dir_mode`](#-redis--log_dir_mode)
 * [`log_file`](#-redis--log_file)
 * [`log_level`](#-redis--log_level)
@@ -479,6 +480,14 @@ Specify directory where to write log entries.
 
 Default value: `$redis::params::log_dir`
 
+##### <a name="-redis--log_dir_group"></a>`log_dir_group`
+
+Data type: `Optional[String[1]]`
+
+Adjust filesystem group for log files.
+
+Default value: `undef`
+
 ##### <a name="-redis--log_dir_mode"></a>`log_dir_mode`
 
 Data type: `Stdlib::Filemode`

manifests/config.pp

@@ -14,7 +14,7 @@
 
   file { $redis::log_dir:
     ensure => directory,
-    group  => $redis::service_group,
+    group  => pick($redis::log_dir_group, $redis::service_group),
     mode   => $redis::log_dir_mode,
     owner  => $redis::service_user,
   }

manifests/init.pp

@@ -81,6 +81,8 @@
 #   Set max ziplist values for lists.
 # @param log_dir
 #   Specify directory where to write log entries.
+# @param log_dir_group
+#   Adjust filesystem group for log files.
 # @param log_dir_mode
 #   Adjust mode for directory containing log files.
 # @param log_file
@@ -385,6 +387,7 @@
   Integer[0] $list_max_ziplist_entries                           = 512,
   Integer[0] $list_max_ziplist_value                             = 64,
   Stdlib::Absolutepath $log_dir                                  = $redis::params::log_dir,
+  Optional[String[1]] $log_dir_group                             = undef,
   Stdlib::Filemode $log_dir_mode                                 = $redis::params::log_dir_mode,
   String $log_file                                               = 'redis.log',
   Redis::LogLevel $log_level                                     = 'notice',

spec/classes/redis_spec.rb

@@ -1020,9 +1020,22 @@ class { 'redis':
       end
 
       describe 'with parameter: service_group' do
-        let(:params) { { service_group: '_VALUE_' } }
+        describe 'with defaults' do
+          let(:params) { { service_group: '_VALUE_' } }
 
-        it { is_expected.to contain_file('/var/log/redis').with_group('_VALUE_') }
+          it { is_expected.to contain_file('/var/log/redis').with_group('_VALUE_') }
+        end
+
+        describe 'with parameter: log_dir_group' do
+          let(:params) do
+            {
+              log_dir_group: 'logdirgroup',
+              service_group: '_VALUE_'
+            }
+          end
+
+          it { is_expected.to contain_file('/var/log/redis').with_group('logdirgroup') }
+        end
       end
 
       describe 'with parameter: service_name' do