Skip to content

Conversation

@edison1105
Copy link
Member

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/slotParentInstance

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.9 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 108 kB 40.4 kB 36.3 kB
vue.global.prod.js 166 kB 60.4 kB 53.7 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.9 kB 18.7 kB 17.1 kB
createApp 57 kB 21.9 kB 20 kB
createApp + vaporInteropPlugin 91.1 kB (+95 B) 34 kB (+37 B) 30.7 kB (+97 B)
createVaporApp 34.7 kB (+58 B) 13.3 kB (+30 B) 12.2 kB (+29 B)
createSSRApp 61.3 kB 23.7 kB 21.6 kB
defineCustomElement 63.1 kB 23.8 kB 21.7 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 10, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14074

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14074

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14074

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14074

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14074

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14074

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14074

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14074

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14074

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14074

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14074

vue

npm i https://pkg.pr.new/vue@14074

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14074

commit: 3e8e12c

track slot owners and consumers to keep `instance.parent` accurate in slot context
@edison1105 edison1105 force-pushed the edison/fix/slotParentInstance branch from 3b5f994 to 457b41a Compare November 11, 2025 09:27
@edison1105 edison1105 changed the title fix(runtime-vapor): track actual parent instance for slot children fix(runtime-vapor): separate slot owner and consumer contexts Nov 11, 2025
@edison1105 edison1105 force-pushed the edison/fix/slotParentInstance branch from d262db5 to 1a6b888 Compare November 11, 2025 13:40
@edison1105 edison1105 force-pushed the edison/fix/slotParentInstance branch from 1a6b888 to 8cacccb Compare November 12, 2025 00:26
@edison1105 edison1105 force-pushed the edison/fix/slotParentInstance branch 3 times, most recently from 35db0bd to b4d4e49 Compare November 12, 2025 09:51
@edison1105 edison1105 force-pushed the edison/fix/slotParentInstance branch from b4d4e49 to 3e8e12c Compare November 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants