Add GetMockBuilderGetMockToCreateMockRector rule to rector (#4951)

Author: sambhavp96

module/VuFind/src/VuFindTest/Unit/RecommendDeferredTestCase.php

@@ -81,8 +81,7 @@ protected function getMockResults($params = null)
         if (null === $params) {
             $params = $this->getMockParams();
         }
-        $results = $this->getMockBuilder(\VuFind\Search\Solr\Results::class)
-            ->disableOriginalConstructor()->getMock();
+        $results = $this->createMock(\VuFind\Search\Solr\Results::class);
         $results->method('getParams')->willReturn($params);
         return $results;
     }
@@ -99,8 +98,7 @@ protected function getMockParams($query = null)
         if (null === $query) {
             $query = new \VuFindSearch\Query\Query('foo', 'bar');
         }
-        $params = $this->getMockBuilder(\VuFind\Search\Solr\Params::class)
-            ->disableOriginalConstructor()->getMock();
+        $params = $this->createMock(\VuFind\Search\Solr\Params::class);
         $params->method('getQuery')->willReturn($query);
         return $params;
     }

module/VuFind/tests/unit-tests/src/VuFindTest/AjaxHandler/CommentRecordTest.php

@@ -150,7 +150,7 @@ public function testSuccessfulTransaction(): void
             ->willReturn(1);
         $this->container->set(CommentsServiceInterface::class, $mockCommentsService);
 
-        $driver = $this->getMockBuilder(DefaultRecord::class)->getMock();
+        $driver = $this->createMock(DefaultRecord::class);
         $driver->expects($this->once())
             ->method('isRatingAllowed')
             ->willReturn(true);

module/VuFind/tests/unit-tests/src/VuFindTest/AjaxHandler/RecommendTest.php

@@ -63,8 +63,7 @@ protected function getMockParams($query = null)
         if (null === $query) {
             $query = new \VuFindSearch\Query\Query('foo', 'bar');
         }
-        $params = $this->getMockBuilder(\VuFind\Search\Solr\Params::class)
-            ->disableOriginalConstructor()->getMock();
+        $params = $this->createMock(\VuFind\Search\Solr\Params::class);
         $params->method('getQuery')->willReturn($query);
         return $params;
     }
@@ -81,8 +80,7 @@ protected function getMockResults($params = null): Results
         if (null === $params) {
             $params = $this->getMockParams();
         }
-        $results = $this->getMockBuilder(Results::class)
-            ->disableOriginalConstructor()->getMock();
+        $results = $this->createMock(Results::class);
         $results->method('getParams')->willReturn($params);
         return $results;
     }

module/VuFind/tests/unit-tests/src/VuFindTest/AjaxHandler/SystemStatusTest.php

@@ -142,7 +142,7 @@ public function testSuccessfulResponse(): void
      */
     protected function getMockRequestParams(array $requestParams = []): Params
     {
-        $params = $this->getMockBuilder(Params::class)->getMock();
+        $params = $this->createMock(Params::class);
         $params->method('fromQuery')
             ->willReturnCallback(
                 function ($param, $default = null) use ($requestParams) {

module/VuFind/tests/unit-tests/src/VuFindTest/Auth/ManagerTest.php

@@ -96,9 +96,7 @@ public function testGetSelectableAuthOptions(): void
 
         // Advanced case -- ChoiceAuth's getSelectableAuthOptions returns false.
         $pm = $this->getMockPluginManager();
-        $mockChoice = $this->getMockBuilder(\VuFind\Auth\ChoiceAuth::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $mockChoice = $this->createMock(\VuFind\Auth\ChoiceAuth::class);
         $mockChoice->method('getSelectableAuthOptions')->willReturn(false);
         $pm->setService('ChoiceAuth2', $mockChoice);
         $config = ['Authentication' => ['method' => 'ChoiceAuth2']];

module/VuFind/tests/unit-tests/src/VuFindTest/Auth/MultiILSTest.php

@@ -248,9 +248,7 @@ protected function getMockMultiBackend(array $onlyMethods = []): MockObject&Mult
         $onlyMethods[] = 'getConfig';
         $onlyMethods[] = 'patronLogin';
         $configManager = $this->container->get(\VuFind\Config\ConfigManagerInterface::class);
-        $ilsAuth = $this->getMockBuilder(\VuFind\Auth\ILSAuthenticator::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $ilsAuth = $this->createMock(\VuFind\Auth\ILSAuthenticator::class);
         $driverManager
             = $this->getMockBuilder(\VuFind\ILS\Driver\PluginManager::class)
             ->setConstructorArgs([$this->container])

module/VuFind/tests/unit-tests/src/VuFindTest/CSV/ImporterTest.php

@@ -249,8 +249,7 @@ public function testEncodingMismatch(): void
      */
     public function testImportInLiveMode(): void
     {
-        $mockWriter = $this->getMockBuilder(\VuFind\Solr\Writer::class)
-            ->disableOriginalConstructor()->getMock();
+        $mockWriter = $this->createMock(\VuFind\Solr\Writer::class);
         $mockWriter->expects($this->once())->method('save')->with(
             $this->equalTo('Solr'),
             $this->callback(
@@ -284,8 +283,7 @@ function ($doc) {
      */
     public function testImportInSmallBatches(): void
     {
-        $mockWriter = $this->getMockBuilder(\VuFind\Solr\Writer::class)
-            ->disableOriginalConstructor()->getMock();
+        $mockWriter = $this->createMock(\VuFind\Solr\Writer::class);
         $mockWriter->expects($this->exactly(3))->method('save')->with(
             $this->equalTo('Solr'),
             $this->callback(

module/VuFind/tests/unit-tests/src/VuFindTest/Config/YamlReaderTest.php

@@ -64,9 +64,7 @@ public function testCacheWrite()
             ->willReturn(null);
         $cache->expects($this->once())->method('setItem')
             ->with($this->matchesRegularExpression('/\d+/'), $this->equalTo($yamlData));
-        $manager = $this->getMockBuilder(\VuFind\Cache\Manager::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $manager = $this->createMock(\VuFind\Cache\Manager::class);
         $manager->expects($this->once())->method('getCache')
             ->with($this->equalTo('yaml'))
             ->willReturn($cache);
@@ -95,9 +93,7 @@ public function testCacheRead()
         $cache->expects($this->once())->method('getItem')
             ->willReturn($yamlData);
         $cache->expects($this->never())->method('setItem');
-        $manager = $this->getMockBuilder(\VuFind\Cache\Manager::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $manager = $this->createMock(\VuFind\Cache\Manager::class);
         $manager->expects($this->once())->method('getCache')
             ->with($this->equalTo('yaml'))
             ->willReturn($cache);
@@ -124,9 +120,7 @@ public function testCacheForcedReload()
         $cache->expects($this->exactly(2))->method('getItem')
             ->willReturn($yamlData);
         $cache->expects($this->never())->method('setItem');
-        $manager = $this->getMockBuilder(\VuFind\Cache\Manager::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $manager = $this->createMock(\VuFind\Cache\Manager::class);
         $manager->expects($this->exactly(2))->method('getCache')
             ->with($this->equalTo('yaml'))
             ->willReturn($cache);

module/VuFind/tests/unit-tests/src/VuFindTest/Content/Covers/BokinfoTest.php

@@ -58,12 +58,8 @@ class BokinfoTest extends \PHPUnit\Framework\TestCase
      */
     protected function getMockRequest(): Request
     {
-        $request = $this->getMockBuilder(Request::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $headers = $this->getMockBuilder(Headers::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $request = $this->createMock(Request::class);
+        $headers = $this->createMock(Headers::class);
         $request->expects($this->once())->method('getHeaders')
             ->willReturn($headers);
         $headers->expects($this->once())->method('addHeaderLine')
@@ -81,9 +77,7 @@ protected function getMockRequest(): Request
      */
     protected function getMockResponse(): Response
     {
-        return $this->getMockBuilder(Response::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        return $this->createMock(Response::class);
     }
 
     /**
@@ -93,9 +87,7 @@ protected function getMockResponse(): Response
      */
     protected function getMockClient(): Client
     {
-        $client = $this->getMockBuilder(Client::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $client = $this->createMock(Client::class);
         $client->expects($this->once())->method('setOptions')
             ->with($this->equalTo(['useragent' => 'VuFind', 'keepalive' => true]));
         return $client;
@@ -108,9 +100,7 @@ protected function getMockClient(): Client
      */
     protected function getMockService(): HttpService
     {
-        $service = $this->getMockBuilder(HttpService::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $service = $this->createMock(HttpService::class);
         $url1 = 'https://api.bokinfo.se/book/get/9789129697285';
         $url2 = 'https://fake-url';
         $client1 = $this->getMockClient();

module/VuFind/tests/unit-tests/src/VuFindTest/Content/Covers/OrbTest.php

@@ -59,9 +59,7 @@ protected function getLoader(?string $fixtureFile = null, string $expectedEAN =
     {
         $loader = new Orb('http://foo', 'fakeuser', 'fakekey');
         if ($fixtureFile) {
-            $mockDownloader = $this->getMockBuilder(CachingDownloader::class)
-                ->disableOriginalConstructor()
-                ->getMock();
+            $mockDownloader = $this->createMock(CachingDownloader::class);
             $fixture = $this->getFixture($fixtureFile);
             $mockDownloader->expects($this->once())->method('downloadJson')
                 ->with($this->equalTo("https://fakeuser:fakekey@http://foo/products?eans=$expectedEAN&sort=ean_asc"))