-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Description
Hi, thanks for this little handy script!
I noticed when doing a bulk build of all the Bibles that the testament combination is not working that well on line 13 so I would suggest the following fix
# load the list of books per/testament
testaments = bible_mod.get_structure()._books
# merge the books
books = []
for testament in testaments:
books += testaments[testament]
This way it working even if there is not new or old testament books in the translation.
I have forked the repo and will be using it to setup a major update to the old getBible v1 API so not all the changes is that practical (since I am trying to hold to some v1 conventions), but if I run into any other issue I will be sure to let you know.
Metadata
Metadata
Assignees
Labels
No labels