Skip to content

feat: expose Forgejo and Gitea repository imports#273

Merged
mariusvniekerk merged 3 commits into
mainfrom
expose-forge-import-ui
May 8, 2026
Merged

feat: expose Forgejo and Gitea repository imports#273
mariusvniekerk merged 3 commits into
mainfrom
expose-forge-import-ui

Conversation

@mariusvniekerk
Copy link
Copy Markdown
Collaborator

Add Forgejo and Gitea to the settings import provider selector with public default hosts and non-nested owner patterns. Cover provider defaults, validation, and preview request payloads in component and Playwright settings import tests.

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (e473d97)

Summary verdict: One medium testing gap remains; no security issues were identified.

Medium

  • frontend/tests/e2e-full/settings-globs.spec.ts:204
    The added e2e coverage intercepts /api/v1/repos/preview, so it does not exercise the real HTTP API or SQLite-backed import flow for the new Forgejo/Gitea maintainer workflow. Add or adjust e2e coverage to hit the real server endpoints with configured Forgejo/Gitea test providers and verify preview and add behavior through the actual API/database path.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (ca095b6)

No Medium, High, or Critical issues were reported.

All review agents found no actionable findings in scope.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (979f85b)

No Medium, High, or Critical findings were reported; the reviewed changes look clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from e4e3382 to d8deb67 Compare May 7, 2026 20:13
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 979f85b to af4a39d Compare May 7, 2026 20:13
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (af4a39d)

No Medium, High, or Critical issues found across the reviews.

All agents that reported results found the code clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from d8deb67 to 4a1d6f2 Compare May 7, 2026 20:27
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from af4a39d to 1a423d5 Compare May 7, 2026 20:28
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (1a423d5)

Summary verdict: One medium test coverage gap remains; no high or critical issues were reported.

Medium

  • frontend/tests/e2e-full/settings-globs.spec.ts:215
    The new e2e flow previews Forgejo repositories but switches to Gitea before submitting, so Forgejo bulk add, config persistence, and tracked-repo update paths are not exercised despite the feature exposing Forgejo imports.
    Fix: Add a Forgejo submit/assertion path, either before switching providers or in a separate e2e test, and verify /api/v1/settings plus /api/v1/repos include the Forgejo repository.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 4a1d6f2 to 0d179bb Compare May 7, 2026 20:51
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 1a423d5 to 0f0e555 Compare May 7, 2026 20:51
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (0f0e555)

No Medium, High, or Critical findings were reported.

All review agents found the code clean or reported no actionable issues.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (58084ce)

No Medium, High, or Critical findings were reported.

All reviewing agents found the code clean or reported no actionable issues.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 437a11d to d1ba10f Compare May 7, 2026 21:54
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 58084ce to d986ff4 Compare May 7, 2026 21:55
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (d986ff4)

No Medium, High, or Critical findings were reported; the reviewed code is clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from d1ba10f to a7d9ee2 Compare May 7, 2026 22:12
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from d986ff4 to b54504c Compare May 7, 2026 22:12
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (b54504c)

No Medium, High, or Critical issues found across the reviews.

All reporting agents that provided findings agreed the code is clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from a7d9ee2 to 7531023 Compare May 7, 2026 22:37
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from b54504c to 0af0a2f Compare May 7, 2026 22:37
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (0af0a2f)

No Medium, High, or Critical findings were reported.

All agents that provided findings agree the code is clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 7531023 to 3ed9108 Compare May 8, 2026 00:30
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 0af0a2f to c60a49a Compare May 8, 2026 00:30
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 8, 2026

roborev: Combined Review (c60a49a)

No Medium, High, or Critical findings were reported.

All review outputs are clean; no actionable PR findings to post.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 3ed9108 to 9792300 Compare May 8, 2026 00:38
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from c60a49a to 1587df4 Compare May 8, 2026 00:38
@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 9792300 to 21aeb76 Compare May 8, 2026 00:42
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 1587df4 to 5bc48df Compare May 8, 2026 00:42
@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 21aeb76 to 3cccbd1 Compare May 8, 2026 00:44
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 5bc48df to 8434a50 Compare May 8, 2026 00:45
@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 3cccbd1 to 4e40333 Compare May 8, 2026 00:47
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 8434a50 to 7ddccbc Compare May 8, 2026 00:47
@mariusvniekerk mariusvniekerk force-pushed the import-forge-provider-repos branch from 4e40333 to 5c5d8e1 Compare May 8, 2026 00:48
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from 7ddccbc to ff3d59f Compare May 8, 2026 00:49
Base automatically changed from import-forge-provider-repos to main May 8, 2026 00:50
Add Forgejo and Gitea to the settings import provider selector with public default hosts and non-nested owner patterns. Cover provider defaults, validation, and preview request payloads in component and Playwright settings import tests.
Seed Forgejo and Gitea repository readers in the isolated e2e server so the settings import workflow previews and adds provider repositories through the actual HTTP and SQLite-backed paths.
The settings import e2e previewed Forgejo repositories but only submitted the later Gitea selection. Submit and assert a Forgejo import first so the test covers bulk add, settings persistence, and tracked repo updates for Forgejo before exercising the Gitea path.
@mariusvniekerk mariusvniekerk force-pushed the expose-forge-import-ui branch from ff3d59f to 7bfa574 Compare May 8, 2026 00:50
@mariusvniekerk mariusvniekerk merged commit 1e4bc99 into main May 8, 2026
8 of 9 checks passed
@mariusvniekerk mariusvniekerk deleted the expose-forge-import-ui branch May 8, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant