Remove emptyOption after using it to fill the options array (#221)

Co-authored-by: Luke Towers <[email protected]>

Author: mjauvin

src/Html/FormBuilder.php

@@ -412,6 +412,7 @@ public function select(string $name, array $list = [], string|array|null $select
     {
         if (array_key_exists('emptyOption', $options)) {
             $list = ['' => $options['emptyOption']] + $list;
+            unset($options['emptyOption']);
         }
 
         // When building a select box the "value" attribute is really the selected one

tests/Html/FormBuilderTest.php

@@ -319,4 +319,25 @@ public function testButtonSubmitType()
         $this->assertElementAttributeEquals('type', 'submit', $result);
         $this->assertElementContainsText('Apply', $result);
     }
+
+    /**
+     * @testdox can create a select element with an empty option without emptyOption appearing as an attribute.
+     */
+    public function testSelectWithEmptyOption()
+    {
+        $result = $this->formBuilder->select(
+            name: 'my-select',
+            list: ['1' => 'Option 1', '2' => 'Option 2'],
+            selected: null,
+            options: ['emptyOption' => 'Please select', 'class' => 'form-control']
+        );
+
+        $this->assertElementIs('select', $result);
+        $this->assertElementAttributeEquals('name', 'my-select', $result);
+        $this->assertElementAttributeEquals('class', 'form-control', $result);
+        $this->assertElementDoesntHaveAttribute('emptyOption', $result);
+        $this->assertStringContainsString('<option value="">Please select</option>', $result);
+        $this->assertStringContainsString('<option value="1">Option 1</option>', $result);
+        $this->assertStringContainsString('<option value="2">Option 2</option>', $result);
+    }
 }