Skip to content

Conversation

@ArmandPhilippot
Copy link
Member

Changes

  • Adds missing JSDoc for some utilities exported from astro:i18n
  • Fixes a JSDoc example that was using the wrong helper.
  • Normalizes how those utilities are exported.

cc @ematipico Since you were in T&D when the associated Docs PR (withastro/docs#12264) was discussed. I'm not sure if I got this point right:

The actual code should be moved away from internal code (this is a re-export)

Testing

This shouldn't break any tests, the exports are still available.

Docs

Related to withastro/docs#12264

/cc @withastro/maintainers-docs for feedback! (I mostly copy/paste what was in the docs PR)

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: 84522ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 31, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @ArmandPhilippot , that's exactly what I meat!

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #14703 will not alter performance

Comparing ArmandPhilippot:docs/add-astro-i18n-jsdoc (84522ba) with main (9be54c7)

Summary

✅ 6 untouched

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArmandPhilippot ArmandPhilippot merged commit 970ac0f into withastro:main Nov 3, 2025
27 checks passed
@ArmandPhilippot ArmandPhilippot deleted the docs/add-astro-i18n-jsdoc branch November 3, 2025 13:23
@astrobot-houston astrobot-houston mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants