Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Astro officially only supports node >=22.12, and in practice ^20.19.5 as well. But that's not enough for our language tools tests
  • Allows bypassing the version check

Testing

Should pass

Docs

N/A, internal

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Nov 5, 2025
@florian-lefebvre florian-lefebvre self-assigned this Nov 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

⚠️ No Changeset found

Latest commit: 3cb1ba7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 🚨 action Modifies GitHub Actions pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Nov 5, 2025
@florian-lefebvre
Copy link
Member Author

@Princesseuh I think I'll need your help on this one. The cleanup of content collections probably impacts some stuff in language tools. Some tests are failing but I'm pretty sure they're supposed to for content intellisense?

@Princesseuh
Copy link
Member

Princesseuh commented Nov 5, 2025

@Princesseuh I think I'll need your help on this one. The cleanup of content collections probably impacts some stuff in language tools. Some tests are failing but I'm pretty sure they're supposed to for content intellisense?

The CI fails seems to be in astro sync?

EDIT: ah no I see the 22 ones, you can just skip entries with _. We skip those tests for now.

@florian-lefebvre
Copy link
Member Author

Ah I didn't see there were still node version errors, I'll look into that. I was talking about this one: https://github.com/withastro/astro/actions/runs/19107585328/job/54595799564?pr=14717#step:7:41

@florian-lefebvre
Copy link
Member Author

@github-actions github-actions bot removed pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Nov 6, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review November 6, 2025 16:43
@florian-lefebvre florian-lefebvre merged commit a967dae into next Nov 6, 2025
21 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/bypass-node-version-check branch November 6, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants