-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: skip node version check in language tools tests #14717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@Princesseuh I think I'll need your help on this one. The cleanup of content collections probably impacts some stuff in language tools. Some tests are failing but I'm pretty sure they're supposed to for content intellisense? |
The CI fails seems to be in astro sync? EDIT: ah no I see the 22 ones, you can just skip entries with _. We skip those tests for now. |
|
Ah I didn't see there were still node version errors, I'll look into that. I was talking about this one: https://github.com/withastro/astro/actions/runs/19107585328/job/54595799564?pr=14717#step:7:41 |
|
Vite uses newer APIs unfortunately: https://discord.com/channels/830184174198718474/1070208455329198190/1435939308853792809 |
Changes
Testing
Should pass
Docs
N/A, internal