-
Notifications
You must be signed in to change notification settings - Fork 667
[cmd3] Add Commands v3-compatible SydIdRoutine #8304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2027
Are you sure you want to change the base?
Conversation
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
commandsv3/src/main/java/org/wpilib/commands3/sysid/SysIdRoutine.java
Outdated
Show resolved
Hide resolved
|
Additional questions:
|
Gold856
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't do m_ for public fields. At least, that's the general convention across WPILib (it's not super formalized). Separately, we should clean it up in the v2 SysIdRoutine.
Cleanup of v2 is planned for a followup PR because I wanted to keep this PR focused, but if it's not too much of a scope creep I can do it here I suppose. |
| * multiple times in a single logfile, the user will need to select which of the tests to use for | ||
| * the fit in the analysis tool. | ||
| */ | ||
| public class SysIdRoutine extends SysIdRoutineLog { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class should have tests. The v2 SysIdRoutine tests are a good starting point to copy over.
Because
SysIdRoutineis contained within the Commands v2 library, an equivalent is needed for Commands v3 to enable SysId usage.Feedback sought on child command names.