Skip to content

CA-423574: avoid losing stacktraces in Xenopsd #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwintorok merged 2 commits into from
Feb 5, 2026
Merged

CA-423574: avoid losing stacktraces in Xenopsd #6891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b45f1
CA-423574: Xenops_task: avoid losing stacktraces when tracing is enabled
edwintorok Feb 4, 2026
3401127
CA-432574: Xenopsd: avoid losing stacktraces in with_reservation
edwintorok Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ocaml/xenopsd/lib/xenops_task.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,10 @@ let with_tracing ~name ~task f =
result
with exn ->
let backtrace = Printexc.get_raw_backtrace () in
Backtrace.is_important exn ;
let error = (exn, backtrace) in
let _ : (Span.t option, exn) result = Tracer.finish span ~error in
raise exn
Printexc.raise_with_backtrace exn backtrace
)
| Error e ->
D.warn "Failed to start tracing: %s" (Printexc.to_string e) ;
Expand Down
6 changes: 5 additions & 1 deletion ocaml/xenopsd/xc/xenops_server_xen.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,11 @@ module Mem = struct
~default:(min, ("none", min))
(reserve_memory_range dbg min max)
in
try f amount id with e -> delete_reservation dbg id ; raise e
try f amount id
with e ->
let bt = Printexc.get_raw_backtrace () in
delete_reservation dbg id ;
Printexc.raise_with_backtrace e bt

(** Transfer this 'reservation' to the given domain id *)
let transfer_reservation_to_domain_exn dbg domid (reservation_id, amount) =
Expand Down
Loading