VLAN support?

[Nowatel]

Hi,

Is there a way to support vlan's via xdp-cpumap-tc? As I understand we can only redirect the traffic to the physical nic like eth0 as they have xps_cpus. Virtual interfaces like eth0.123 don't have multiple xps_cpus that we can use. I didn't see any example involving shaping on the vlan via this method.

[interduo]

Hi @Nowatel did You find the answer for that?

[Nowatel]

Hi @Nowatel did You find the answer for that?

Unfortunately it's not possible. As referenced in mentioned topic it can only be done via additional libreqos box.

[tohojo]

There is already VLAN support. The packet parsing code already handles (i.e., skips) VLAN tags when it encounters them: https://github.com/xdp-project/xdp-cpumap-tc/blob/master/src/xdp_iphash_to_cpu_kern.c#L99-L120

If you just run the XDP program on the physical NIC (i.e., not the virtual VLAN interface), you'll get the packets redirected to the right CPU based on the inner IP header, and the network stack will take over on that CPU afterwards, handling the VLAN tagging and routing the packets to the stacked VLAN interface.

So it should be quite possible to use this as-is even in a VLAN setup...

[netoptimizer]

There is already VLAN support.

Yes, even double-tagged VLAN support (which is run in production at @danielnielsennumber1 ).

As @thebracket noticed in LibreQoE/LibreQoS#26 the catch is that you need to disable hardware VLAN offloading on the NIC.
This is needed for XDP, as XDP need to vlan headers inline in the packet (in the future with XDP-hints this will be resolved).

Use commands:

 ethtool -K (interface-out) rxvlan off
 ethtool -K (interface-in) rxvlan off

The setup script bin/set_irq_affinity_with_rss_conf.sh also disable hardware offloaded VLAN.

[interduo]

@netoptimizer So using the same card with two VLANs as inbound and outbound interface is possible? (case described here: LibreQoE/LibreQoS#48)

[thebracket]

I haven't tested it, but it really should work. Make your parent bridge contain the two VLANs (and not the parent interface), and use those as the two interfaces. The packets coming in will still be seen by the right xdp/tc programs, which will figure out where the payload is relative to the tags - so I can't think of a good reason why it wouldn't work. NO idea how well that would perform.

…

On Mon, Oct 10, 2022 at 2:59 PM Interduo ***@***.***> wrote: So using the same card with two VLANs as inbound and outbound interface is possible? — Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRU435YL7OCE5TVK3IGOUDWCRYSVANCNFSM5LHZH2GQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>