-
Notifications
You must be signed in to change notification settings - Fork 45
Description
From my triage on Mac OS (10.14.4, Mojave) and Uuntu 18.04, there two tips were required to successfully build inspect.js and inspect.wasm with Emscripton, based on the guides at https://aomedia.googlesource.com/aom/#emscripten-builds.
- Configure the build with cmake,
only av1-normativ branch worked, and the mater branch failed with cmake.
(To see which parts failed, please checkout Emscripton build fails with both Ubuntu and Mac OS to generate inspect.js #78 and Emscripton build error on Mac OS #79)
(FYI, I've run: "cmake ../aom -DENABLE_CCACHE=1 -DENABLE_DOCS=0 -DENABLE_TESTS=0 -DAOM_TARGET_CPU=generic -DCONFIG_ACCOUNTING=1 -DCONFIG_INSPECTION=1 -DCONFIG_MULTITHREAD=0 -DCONFIG_RUNTIME_CPU_DETECT=0 -DCONFIG_WEBM_IO=0 -DCMAKE_TOOLCHAIN_FILE=/Users/yushin/workspace/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake && make -j12 inspect")
- Before doing "make inspect", I needed below change to remove the build error.
i.e. "-std=c99" --> "-std=gnu99" in [aom directorory]/build/cmake/aom_configure.cmake
$ git diff
diff --git a/build/cmake/aom_configure.cmake b/build/cmake/aom_configure.cmake
index 2b59c61a9..ec34cf9b0 100644
--- a/build/cmake/aom_configure.cmake
+++ b/build/cmake/aom_configure.cmake
@@ -259,7 +259,7 @@ if(MSVC)
add_compiler_flag_if_supported("/WX")
endif()
else()
- require_c_flag("-std=c99" YES)
- require_c_flag("-std=gnu99" YES)
add_compiler_flag_if_supported("-Wall")
add_compiler_flag_if_supported("-Wdisabled-optimization")
add_compiler_flag_if_supported("-Wextra")
I hope this helps saving your time building aom analyzer!