Skip to content

Commit ddffd24

Browse files
committed
chore(kms-connector): more granular metrics
1 parent b818dba commit ddffd24

19 files changed

+424
-294
lines changed

kms-connector/.sqlx/query-05f22646520c5835fc3235aa6378dccd4436ca4a07ab25a9c8abe21760d5b202.json

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

kms-connector/.sqlx/query-17db0e005e1367157721bf62877d735a9fb755f5d9afe72f069a1872ff1b7fd6.json

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

kms-connector/.sqlx/query-a70444056f27bd68660c86bade10eccfac9cb5fd677de32dcc7bea043d3ca237.json

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

kms-connector/.sqlx/query-f4cec78c0611edc0cf747320db7f0fb1c9eaec89303c3f3e45617b155fa9aed8.json

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

kms-connector/Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

kms-connector/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ gw-listener.path = "crates/gw-listener"
1818
kms-worker.path = "crates/kms-worker"
1919
tx-sender.path = "crates/tx-sender"
2020
connector-utils.path = "crates/utils"
21-
fhevm_gateway_bindings = { git = "https://github.com/zama-ai/fhevm.git", tag = "v0.10.0-2", default-features = false }
21+
fhevm_gateway_bindings = { git = "https://github.com/zama-ai/fhevm.git", tag = "v0.10.0", default-features = false }
2222
kms-grpc = { git = "https://github.com/zama-ai/kms.git", tag = "v0.12.4", default-features = true }
2323
bc2wrap = { git = "https://github.com/zama-ai/kms.git", tag = "v0.12.4", default-features = true }
2424
tfhe = "=1.4.0-alpha.3"

kms-connector/crates/gw-listener/src/core/gw_listener.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use crate::{
33
core::{publish::update_last_block_polled, publish_event},
44
monitoring::{
55
health::State,
6-
metrics::{EVENT_RECEIVED_COUNTER, EVENT_RECEIVED_ERRORS, EVENT_STORAGE_ERRORS},
6+
metrics::{EVENT_RECEIVED_COUNTER, EVENT_RECEIVED_ERRORS},
77
},
88
};
99
use alloy::{
@@ -198,14 +198,19 @@ where
198198
match events.next().await {
199199
Some(Ok((event, log))) => {
200200
*last_block = log.block_number;
201-
EVENT_RECEIVED_COUNTER.inc();
201+
EVENT_RECEIVED_COUNTER
202+
.with_label_values(&[event_type.as_str()])
203+
.inc();
204+
202205
let db = self.db_pool.clone();
203206
spawn_with_limit(handle_gateway_event(db, event.into(), log.block_number))
204207
.await;
205208
}
206209
Some(Err(err)) => {
207210
error!("Error while listening for {event_type} events: {err}");
208-
EVENT_RECEIVED_ERRORS.inc();
211+
EVENT_RECEIVED_ERRORS
212+
.with_label_values(&[event_type.as_str()])
213+
.inc();
209214
continue;
210215
}
211216
None => break error!("Alloy Provider was dropped for {event_type}"),
@@ -274,7 +279,6 @@ async fn handle_gateway_event(
274279
);
275280
if let Err(err) = publish_event(&db_pool, event, block_number).await {
276281
error!("Failed to publish event: {err}");
277-
EVENT_STORAGE_ERRORS.inc();
278282
}
279283
}
280284

kms-connector/crates/gw-listener/src/core/publish.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use crate::monitoring::metrics::EVENT_STORED_COUNTER;
21
use alloy::primitives::U256;
32
use anyhow::anyhow;
43
use connector_utils::{
@@ -44,7 +43,6 @@ pub async fn publish_event(
4443

4544
if query_result.rows_affected() == 1 {
4645
info!("Event successfully stored in DB!");
47-
EVENT_STORED_COUNTER.inc();
4846
} else {
4947
warn!("Unexpected query result while publishing event: {query_result:?}");
5048
}
Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,20 @@
1-
use prometheus::{IntCounter, register_int_counter};
1+
use prometheus::{IntCounterVec, register_int_counter_vec};
22
use std::sync::LazyLock;
33

4-
pub static EVENT_RECEIVED_COUNTER: LazyLock<IntCounter> = LazyLock::new(|| {
5-
register_int_counter!(
4+
pub static EVENT_RECEIVED_COUNTER: LazyLock<IntCounterVec> = LazyLock::new(|| {
5+
register_int_counter_vec!(
66
"kms_connector_gw_listener_event_received_counter",
7-
"Number of events received by the GatewayListener"
7+
"Number of events received by the GatewayListener",
8+
&["event_type"]
89
)
910
.unwrap()
1011
});
1112

12-
pub static EVENT_RECEIVED_ERRORS: LazyLock<IntCounter> = LazyLock::new(|| {
13-
register_int_counter!(
14-
"kms_connector_gw_listener_event_received_errors",
15-
"Number of errors encountered by the GatewayListener while receiving events"
16-
)
17-
.unwrap()
18-
});
19-
20-
pub static EVENT_STORED_COUNTER: LazyLock<IntCounter> = LazyLock::new(|| {
21-
register_int_counter!(
22-
"kms_connector_gw_listener_event_stored_counter",
23-
"Number of events stored in DB by the GatewayListener"
24-
)
25-
.unwrap()
26-
});
27-
28-
pub static EVENT_STORAGE_ERRORS: LazyLock<IntCounter> = LazyLock::new(|| {
29-
register_int_counter!(
13+
pub static EVENT_RECEIVED_ERRORS: LazyLock<IntCounterVec> = LazyLock::new(|| {
14+
register_int_counter_vec!(
3015
"kms_connector_gw_listener_event_storage_errors",
31-
"Number of errors encountered by the GatewayListener while trying to store events in DB"
16+
"Number of errors encountered by the GatewayListener while trying to store events in DB",
17+
&["event_type"]
3218
)
3319
.unwrap()
3420
});

0 commit comments

Comments
 (0)