Skip to content

Conversation

@melanciani
Copy link
Contributor

No description provided.

@melanciani melanciani requested a review from a team as a code owner November 27, 2025 19:08
@cla-bot cla-bot bot added the cla-signed label Nov 27, 2025
Copy link
Contributor

@eudelins-zama eudelins-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not passing on main but work on release/0.10.x...

I ran the git diff main..release/0.10.x test-suite command, and there are some differences, notably in the test-suite/e2e/test/delegateUserDecrypt/delegateUserDecryption.ts file, maybe cc @rudy-6-4

@melanciani melanciani force-pushed the melanciani/test/test-suite/main/update_fhevm_0_10_0_6 branch 2 times, most recently from e9138b8 to 7e32f67 Compare November 28, 2025 10:11
@melanciani
Copy link
Contributor Author

melanciani commented Nov 28, 2025

yes @eudelins-zama seems like it has been modified in main recently : https://github.com/zama-ai/fhevm/pull/1092/files

but it is somewhat expected, we should consider new images if anything has been updated in main but not for 0.10, so best thing to do is keep the test-suite images introduced recently by Alex : https://github.com/zama-ai/fhevm/pull/1390/files#diff-6392bf845e5d28c9e71606db47d7889600ded5ba9775f1dfe7264d305e2a9668R41

edit: sorry, looking at it again, I think there's a mistake indeed, as the PRs I showed above are supposed to be the same as the ones included in the 0.10 branch. Let's clarify this

@melanciani melanciani force-pushed the melanciani/test/test-suite/main/update_fhevm_0_10_0_6 branch from 7e32f67 to 986f48e Compare November 28, 2025 10:19
@melanciani melanciani force-pushed the melanciani/test/test-suite/main/update_fhevm_0_10_0_6 branch from 986f48e to 66ca71e Compare November 28, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants