Skip to content

Conversation

@rudy-6-4
Copy link
Contributor

use block time instead of the default now() == transaction time

@cla-bot cla-bot bot added the cla-signed label Nov 28, 2025
@rudy-6-4 rudy-6-4 requested a review from Copilot November 28, 2025 13:16
Copilot finished reviewing on behalf of rudy-6-4 November 28, 2025 13:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the computations table insertion to use block time from blockchain events instead of the default transaction time (NOW()) for the created_at and schedule_order timestamp fields. This ensures more accurate temporal ordering based on when blocks were actually mined rather than when database transactions occur.

Key Changes:

  • Added created_at and schedule_order columns to the INSERT statement for computations
  • Set both timestamp fields to use log.event.block_timestamp from the blockchain event
  • Both fields use the same parameter ($9) for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rudy-6-4 rudy-6-4 force-pushed the rudy/host-listener/use-block-time-for-computations branch from 5e1227c to 6b7cede Compare November 28, 2025 17:15
@rudy-6-4 rudy-6-4 requested a review from Copilot November 28, 2025 17:17
…t & .schedule_order

use block time instead of the default now() == transaction time
@rudy-6-4 rudy-6-4 force-pushed the rudy/host-listener/use-block-time-for-computations branch from 6b7cede to aaf1bca Compare November 28, 2025 17:17
Copilot finished reviewing on behalf of rudy-6-4 November 28, 2025 17:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rudy-6-4 rudy-6-4 marked this pull request as ready for review November 28, 2025 17:30
@rudy-6-4 rudy-6-4 requested a review from a team as a code owner November 28, 2025 17:30
antoniupop
antoniupop previously approved these changes Nov 29, 2025
@rudy-6-4 rudy-6-4 force-pushed the rudy/host-listener/use-block-time-for-computations branch from aaf1bca to b8fcabd Compare November 29, 2025 08:49
@rudy-6-4 rudy-6-4 requested review from a team as code owners November 29, 2025 08:49
@rudy-6-4 rudy-6-4 force-pushed the rudy/host-listener/use-block-time-for-computations branch from b8fcabd to aaf1bca Compare November 29, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants