-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(coprocessor): host-listener, block time in computations.created_at & .schedule_order #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the computations table insertion to use block time from blockchain events instead of the default transaction time (NOW()) for the created_at and schedule_order timestamp fields. This ensures more accurate temporal ordering based on when blocks were actually mined rather than when database transactions occur.
Key Changes:
- Added
created_atandschedule_ordercolumns to the INSERT statement for computations - Set both timestamp fields to use
log.event.block_timestampfrom the blockchain event - Both fields use the same parameter ($9) for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs
Outdated
Show resolved
Hide resolved
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs
Outdated
Show resolved
Hide resolved
5e1227c to
6b7cede
Compare
…t & .schedule_order use block time instead of the default now() == transaction time
6b7cede to
aaf1bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aaf1bca to
b8fcabd
Compare
b8fcabd to
aaf1bca
Compare
use block time instead of the default now() == transaction time