chore: update msrv to 1.91.1

Author: nsarlin-zama

Cargo.toml

@@ -24,7 +24,7 @@ exclude = [
 ]
 
 [workspace.package]
-rust-version = "1.85"
+rust-version = "1.91.1"
 
 [workspace.dependencies]
 aligned-vec = { version = "0.6", default-features = false }

Makefile

@@ -427,21 +427,21 @@ clippy_rustdoc: install_rs_check_toolchain
 		echo "WARNING: skipped clippy_rustdoc, unsupported OS $(OS)"; \
 		exit 0; \
 	fi && \
-	CARGO_TERM_QUIET=true CLIPPYFLAGS="-D warnings" RUSTDOCFLAGS="--no-run --nocapture --test-builder ./scripts/clippy_driver.sh -Z unstable-options" \
+	CARGO_TERM_QUIET=true CLIPPYFLAGS="-D warnings" RUSTDOCFLAGS="--no-run --test-builder ./scripts/clippy_driver.sh -Z unstable-options" \
 		cargo "$(CARGO_RS_CHECK_TOOLCHAIN)" test --doc \
 		--features=boolean,shortint,integer,zk-pok,pbs-stats,strings,experimental \
-		-p tfhe
+		-p tfhe -- --nocapture
 
 .PHONY: clippy_rustdoc_gpu # Run clippy lints on doctests enabling the boolean, shortint, integer and zk-pok
 clippy_rustdoc_gpu: install_rs_check_toolchain
 	if [[ "$(OS)" != "Linux" ]]; then \
 		echo "WARNING: skipped clippy_rustdoc_gpu, unsupported OS $(OS)"; \
 		exit 0; \
 	fi && \
-	CARGO_TERM_QUIET=true CLIPPYFLAGS="-D warnings" RUSTDOCFLAGS="--no-run --nocapture --test-builder ./scripts/clippy_driver.sh -Z unstable-options" \
+	CARGO_TERM_QUIET=true CLIPPYFLAGS="-D warnings" RUSTDOCFLAGS="--no-run --test-builder ./scripts/clippy_driver.sh -Z unstable-options" \
 		cargo "$(CARGO_RS_CHECK_TOOLCHAIN)" test --doc \
 		--features=boolean,shortint,integer,zk-pok,pbs-stats,strings,experimental,gpu \
-		-p tfhe
+		-p tfhe -- --nocapture
 
 .PHONY: clippy_c_api # Run clippy lints enabling the boolean, shortint and the C API
 clippy_c_api: install_rs_check_toolchain
@@ -649,11 +649,19 @@ build_web_js_api: install_rs_build_toolchain install_wasm_pack
 		-- --features=boolean-client-js-wasm-api,shortint-client-js-wasm-api,integer-client-js-wasm-api,zk-pok,extended-types
 
 .PHONY: build_web_js_api_parallel # Build the js API targeting the web browser with parallelism support
+# parallel wasm requires specific build options, see https://github.com/rust-lang/rust/pull/147225
 build_web_js_api_parallel: install_rs_check_toolchain install_wasm_pack
 	cd tfhe && \
 	rustup component add rust-src --toolchain $(RS_CHECK_TOOLCHAIN) && \
-	RUSTFLAGS="$(WASM_RUSTFLAGS) -C target-feature=+atomics,+bulk-memory" rustup run $(RS_CHECK_TOOLCHAIN) \
-		wasm-pack build --release --target=web \
+	RUSTFLAGS="$(WASM_RUSTFLAGS) -C target-feature=+atomics,+bulk-memory \
+		-Clink-arg=--shared-memory \
+		-Clink-arg=--max-memory=1073741824 \
+		-Clink-arg=--import-memory \
+		-Clink-arg=--export=__wasm_init_tls \
+		-Clink-arg=--export=__tls_size \
+		-Clink-arg=--export=__tls_align \
+		-Clink-arg=--export=__tls_base" \
+		rustup run $(RS_CHECK_TOOLCHAIN) wasm-pack build --release --target=web \
 		-- --features=boolean-client-js-wasm-api,shortint-client-js-wasm-api,integer-client-js-wasm-api,parallel-wasm-api,zk-pok,extended-types \
 		-Z build-std=panic_abort,std && \
 	find pkg/snippets -type f -iname workerHelpers.js -exec sed -i "s|const pkg = await import('..\/..\/..');|const pkg = await import('..\/..\/..\/tfhe.js');|" {} \;

backends/tfhe-hpu-backend/src/fw/fw_impl/ilp_div.rs

@@ -659,6 +659,7 @@ pub fn iop_div_corev(
             }
 
             remain_a = Vec::new();
+            #[allow(clippy::needless_range_loop)]
             for i in 0..block_nb {
                 remain_tmp_v[0][i] = &remain_tmp_v[0][i] + &remain_tmp_v[1][i];
                 remain_tmp_v[2][i] = &remain_tmp_v[2][i] + &remain_tmp_v[3][i];

tfhe-fft/src/fft_simd.rs

@@ -54,7 +54,7 @@ pub const H1Y: f64 = -0.38268343236508984f64;
 struct AssertC64Vec<T>(PhantomData<T>);
 impl<T> AssertC64Vec<T> {
     pub const VALID: () = {
-        assert!(core::mem::size_of::<T>() % core::mem::size_of::<c64>() == 0);
+        assert!(core::mem::size_of::<T>().is_multiple_of(core::mem::size_of::<c64>()));
     };
 }
 

tfhe-fft/src/lib.rs

@@ -73,8 +73,6 @@
     clippy::too_many_arguments,
     non_camel_case_types
 )]
-// Should be removed when we raise MSRV above 1.87
-#![allow(clippy::manual_is_multiple_of)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![warn(rustdoc::broken_intra_doc_links)]
 

tfhe-ntt/src/prime.rs

@@ -83,18 +83,18 @@ pub const fn is_prime64(n: u64) -> bool {
     // hand-unrolled for the compiler to optimize divisions
     #[rustfmt::skip]
     {
-        if n %  2 == 0 { return n ==  2; }
-        if n %  3 == 0 { return n ==  3; }
-        if n %  5 == 0 { return n ==  5; }
-        if n %  7 == 0 { return n ==  7; }
-        if n % 11 == 0 { return n == 11; }
-        if n % 13 == 0 { return n == 13; }
-        if n % 17 == 0 { return n == 17; }
-        if n % 19 == 0 { return n == 19; }
-        if n % 23 == 0 { return n == 23; }
-        if n % 29 == 0 { return n == 29; }
-        if n % 31 == 0 { return n == 31; }
-        if n % 37 == 0 { return n == 37; }
+        if n.is_multiple_of(2) { return n ==  2; }
+        if n.is_multiple_of(3) { return n ==  3; }
+        if n.is_multiple_of(5) { return n ==  5; }
+        if n.is_multiple_of(7) { return n ==  7; }
+        if n.is_multiple_of(11) { return n == 11; }
+        if n.is_multiple_of(13) { return n == 13; }
+        if n.is_multiple_of(17) { return n == 17; }
+        if n.is_multiple_of(19) { return n == 19; }
+        if n.is_multiple_of(23) { return n == 23; }
+        if n.is_multiple_of(29) { return n == 29; }
+        if n.is_multiple_of(31) { return n == 31; }
+        if n.is_multiple_of(37) { return n == 37; }
     };
 
     // deterministic miller rabin test, works for any n < 2^64
@@ -104,7 +104,7 @@ pub const fn is_prime64(n: u64) -> bool {
     let mut s = 0;
     let mut d = n - 1;
 
-    while d % 2 == 0 {
+    while d.is_multiple_of(2) {
         s += 1;
         d /= 2;
     }

tfhe-ntt/src/product.rs

@@ -156,7 +156,7 @@ impl Plan {
         factors: impl AsRef<[u64]>,
     ) -> Option<Self> {
         fn try_new_impl(polynomial_size: usize, modulus: u64, primes: &mut [u64]) -> Option<Plan> {
-            if polynomial_size % 2 != 0 {
+            if !polynomial_size.is_multiple_of(2) {
                 return None;
             }
 

tfhe-ntt/src/roots.rs

@@ -7,7 +7,7 @@ pub const fn get_q_s64(p: Div64) -> (u64, u64) {
     let p = p.divisor();
     let mut q = p - 1;
     let mut s = 0;
-    while q % 2 == 0 {
+    while q.is_multiple_of(2) {
         q /= 2;
         s += 1;
     }

tfhe-zk-pok/src/four_squares.rs

@@ -226,7 +226,7 @@ pub fn four_squares(v: u128, sanity_check_mode: ProofSanityCheckMode) -> [u64; 4
 
             let mut d = p - 1;
             let mut s = 0u32;
-            while d % 2 == 0 {
+            while d.is_multiple_of(2) {
                 d /= 2;
                 s += 1;
             }

tfhe/examples/sha256_bool/padding.rs

@@ -8,7 +8,7 @@
 pub fn pad_sha256_input(input: &str) -> Vec<bool> {
     let bytes = if input.starts_with("0x") && is_valid_hex(&input[2..]) {
         let no_prefix = &input[2..];
-        let hex_input = if no_prefix.len() % 2 == 0 {
+        let hex_input = if no_prefix.len().is_multiple_of(2) {
             // hex value can be converted to bytes
             no_prefix.to_string()
         } else {