Skip to content

Commit cc66fbd

Browse files
authored
Merge branch 'master' into file_scan
2 parents 601438b + b4db4c3 commit cc66fbd

File tree

181 files changed

+24086
-10221
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

181 files changed

+24086
-10221
lines changed

be/src/http/action/debug_point_action.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ void BaseDebugPointAction::handle(HttpRequest* req) {
3535
"Disable debug points. please check config::enable_debug_points");
3636
}
3737
std::string result = status.to_json();
38-
LOG(INFO) << "handle request result:" << result;
3938
if (status.ok()) {
4039
HttpChannel::send_reply(req, HttpStatus::OK, result);
4140
} else {

be/src/io/file_factory.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class FileFactory {
107107
static Status create_pipe_reader(const TUniqueId& load_id, io::FileReaderSPtr* file_reader,
108108
RuntimeState* runtime_state, bool need_schema);
109109

110-
static TFileType::type convert_storage_type(TStorageBackendType::type type) {
110+
static Result<TFileType::type> convert_storage_type(TStorageBackendType::type type) {
111111
switch (type) {
112112
case TStorageBackendType::LOCAL:
113113
return TFileType::FILE_LOCAL;
@@ -120,9 +120,8 @@ class FileFactory {
120120
case TStorageBackendType::HDFS:
121121
return TFileType::FILE_HDFS;
122122
default:
123-
throw Exception(Status::FatalError("not match type to convert, from type:{}", type));
123+
return ResultError(Status::FatalError("not match type to convert, from type:{}", type));
124124
}
125-
throw Exception(Status::FatalError("__builtin_unreachable"));
126125
}
127126

128127
private:

be/src/olap/iterators.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ struct IteratorRowRef;
4646
namespace segment_v2 {
4747
struct SubstreamIterator;
4848
}
49-
5049
class StorageReadOptions {
5150
public:
5251
struct KeyRange {
@@ -143,6 +142,9 @@ class StorageReadOptions {
143142
std::map<ColumnId, size_t> vir_cid_to_idx_in_block;
144143
std::map<size_t, vectorized::DataTypePtr> vir_col_idx_to_type;
145144

145+
std::map<int32_t, TColumnAccessPaths> all_access_paths;
146+
std::map<int32_t, TColumnAccessPaths> predicate_access_paths;
147+
146148
std::shared_ptr<vectorized::ScoreRuntime> score_runtime;
147149
CollectionStatisticsPtr collection_statistics;
148150

be/src/olap/rowset/beta_rowset_reader.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ Status BetaRowsetReader::get_segment_iterators(RowsetReaderContext* read_context
103103
_read_options.remaining_conjunct_roots = _read_context->remaining_conjunct_roots;
104104
_read_options.common_expr_ctxs_push_down = _read_context->common_expr_ctxs_push_down;
105105
_read_options.virtual_column_exprs = _read_context->virtual_column_exprs;
106+
107+
_read_options.all_access_paths = _read_context->all_access_paths;
108+
_read_options.predicate_access_paths = _read_context->predicate_access_paths;
109+
106110
_read_options.ann_topn_runtime = _read_context->ann_topn_runtime;
107111
_read_options.vir_cid_to_idx_in_block = _read_context->vir_cid_to_idx_in_block;
108112
_read_options.vir_col_idx_to_type = _read_context->vir_col_idx_to_type;

be/src/olap/rowset/rowset_reader_context.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
#ifndef DORIS_BE_SRC_OLAP_ROWSET_ROWSET_READER_CONTEXT_H
1919
#define DORIS_BE_SRC_OLAP_ROWSET_ROWSET_READER_CONTEXT_H
2020

21+
#include <vector>
22+
2123
#include "io/io_common.h"
2224
#include "olap/column_predicate.h"
2325
#include "olap/olap_common.h"
@@ -90,6 +92,9 @@ struct RowsetReaderContext {
9092
std::map<ColumnId, size_t> vir_cid_to_idx_in_block;
9193
std::map<size_t, vectorized::DataTypePtr> vir_col_idx_to_type;
9294

95+
std::map<int32_t, TColumnAccessPaths> all_access_paths;
96+
std::map<int32_t, TColumnAccessPaths> predicate_access_paths;
97+
9398
std::shared_ptr<vectorized::ScoreRuntime> score_runtime;
9499
CollectionStatisticsPtr collection_statistics;
95100
std::shared_ptr<segment_v2::AnnTopNRuntime> ann_topn_runtime;

0 commit comments

Comments
 (0)