This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Add a file extension check on the validator.#187
Open
lypwig wants to merge 1 commit into1000hz:masterfrom
lypwig:file-ext-check
Open
Add a file extension check on the validator.#187lypwig wants to merge 1 commit into1000hz:masterfrom lypwig:file-ext-check
lypwig wants to merge 1 commit into1000hz:masterfrom
lypwig:file-ext-check
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering the input:
Then, if you select a file with a wrong extension (it's possible even if you fill the
acceptattribute), this will display the error:This file type is not supported.You can also set your valid extensions with:
data-ext=".png, .bmp", in this way you don't have to add theacceptattribute.Note: I think than add the
data-extattribute without argument is a more purified syntax, but I'm waiting for #118 .