This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Element must be visible, or offset() will bring user to top of screen.#561
Open
petski wants to merge 1 commit into1000hz:masterfrom
Open
Element must be visible, or offset() will bring user to top of screen.#561petski wants to merge 1 commit into1000hz:masterfrom
petski wants to merge 1 commit into1000hz:masterfrom
Conversation
In case element is not visible offset() will return `top:0, left:0` Use case: `<input type="radio" required>` where the first radio-item is "hidden" in a collapsable div. If you don't like this change, I can make a feature like `$.fn.validator.Constructor.INPUT_SELECTOR`, but then for focusError.
Contributor
|
I have the same problem. This PR is correct and should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case element is not visible offset() will return
top:0, left:0Use case:
<input type="radio" required>where the first radio-item is"hidden" in a collapsable div.
If you don't like this change, I can make a feature like
$.fn.validator.Constructor.INPUT_SELECTOR, but then for focusError.