Conversation
Owner
|
allowijg arbitrary strings is probably good |
TheV360
commented
Mar 16, 2025
Comment on lines
+122
to
+124
| // TODO: one thing to ask -- if i edit on a "replied" value, will LinkedUsers populate? | ||
| // why is ReactedWith not being set on messages in display_live? | ||
| // why is ReactedWith not set in the message cache?? is there a message cache? |
Contributor
Author
There was a problem hiding this comment.
@12Me21 this acts weird -- i know there probably isn't a message cache anywwaaaay the
Contributor
Author
|
the reason it is acting weird is because you can only attach one react to a post |
TheV360
commented
May 22, 2025
| /// sidebar messages /// | ||
| // TODO: ensure that these are displayed BEFORE any websocket new messages | ||
| Sidebar.display_messages(objects.message, true) | ||
| do_when_ready(_=>Sidebar.display_messages(objects.message, true)) |
Contributor
Author
There was a problem hiding this comment.
this would fix #66, maybe a bit sneaky of me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feel free to critique
here's how it looks presently. i added border radius because i
want the world to explodethought it looked cute.a problem is that it can accept any string. we'll need to filter out to just emoji-core things.
(this'd be a problem because others 'd be able to tack Any message onto a message without the creators' approval. could be fine, if people act normal)
also it's buggy it's really just an mvp for things