Migrate Docker image from tum-gis/3dcitydb-web-map-docker#88
Open
Migrate Docker image from tum-gis/3dcitydb-web-map-docker#88
Conversation
Member
Author
|
Hey @Son-HNguyen, some questions came up:
|
Member
|
@BWibo The TypeScript files should only be built if they have been changed. Otherwise, the built JavaScript files are already stored. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thomashkolbe @clausnagel @Son-HNguyen
This PR migrates the Docker image for the Webclient from tum-gis/3dcitydb-web-map-docker to this repo.
Moreover, it add a build workflow for building
edgeandrelease versionimages and deploying them to ghcr.io and DockerHub. All image are built foramd64andarm64arch.A test image is available here:
https://github.com/3dcitydb/3dcitydb-web-map/pkgs/container/3dcitydb-web-map-client
Please try out the new image and let me know if you come accross any issues.
@benediktschwab Thx for testing the
arm64build.ToDos
README.mdwith Docker content form tum-gis/3dcitydb-web-map-dockeramd64,arm64)edgeimage workflowreleaseimage workflowOffer-->alpineanddebianbased versions, or is onlyalpinefine?debian-slimbase image size is fine.server.jsto usegotinstead of deprecatedrequestlibrarymaster, we need to create a release (v2.0.1) to trigger the build workflows and have a first release version publishedCHANGES.md