Skip to content

Password visibility toggle tooltip #7902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awarzu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Password visibility toggle tooltip #7902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions newIDE/app/src/UI/TextField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
// @flow
import * as React from 'react';
import { I18n } from '@lingui/react';
import { t } from '@lingui/macro';
import IconButton from '@material-ui/core/IconButton';
import MUITextField from '@material-ui/core/TextField';
import Tooltip from '@material-ui/core/Tooltip';
import { type FieldFocusFunction } from '../EventsSheet/ParameterFields/ParameterFieldCommons';
import InputAdornment from '@material-ui/core/InputAdornment';
import Visibility from './CustomSvgIcons/Visibility';
Expand Down Expand Up @@ -347,12 +349,20 @@ const TextField = React.forwardRef<Props, TextFieldInterface>((props, ref) => {
endAdornment:
props.type !== undefined && props.type === 'password' ? (
<InputAdornment position="end">
<IconButton
size="small"
onClick={() => setIsPasswordVisible(!isPasswordVisible)}
<Tooltip
title={
isPasswordVisible
? i18n._(t`Hide password`)
: i18n._(t`Show password`)
}
>
<Visibility />
</IconButton>
<IconButton
size="small"
onClick={() => setIsPasswordVisible(!isPasswordVisible)}
>
<Visibility />
</IconButton>
</Tooltip>
</InputAdornment>
) : props.endAdornment ? (
<InputAdornment
Expand Down