Refractoring + Sepration#19
Open
max-4-3 wants to merge 40 commits into9001:hovudstraumfrom
Open
Conversation
Major refractor coming :)
Share url generation improved/worked upon boi it was well nice
Updated method visibility to private for better encapsulation.
Introduced a new Foreground Service to do uploads in bg Its working rather fine, though its just a basic skeleton.
Notification flow for service, UI is still...
Added support for versioned tags and improved job steps.
Added step to create .env file from encoded secret.
Add workflow_dispatch event with tag_name input.
Added environment variable to force Node.js version and updated action versions for checkout and Java setup.
Updated the Gradle build command to assemble the release APK and added a step to create a GitHub release with the generated APK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some refractoring so it'll be easier to work with ( if wanted )
Added
Discovery.javafor parsing files from intent. It also has some private fn to help the extraction.Added
Uploader.javafor well uploading to the server ( it only uploads and accepts a file object and some callback ).Added a few helper function.
Changed
FtoCustomFileand introduced some more class members/methods.Added a few extra classes. some are not very helpful just a workaround.
Tried to de-couple the code ( uff ).
I think the imports are kinda wonkie. ( i didn't used an IDE )
Supports Android 7.1.0
though didn't fully checked it. but it seems to be working fine.
UI didn't changed.
:)