Skip to content

Comments

Support Guice 4#8

Open
mrpotes wants to merge 3 commits into99soft:masterfrom
awillinger:master
Open

Support Guice 4#8
mrpotes wants to merge 3 commits into99soft:masterfrom
awillinger:master

Conversation

@mrpotes
Copy link

@mrpotes mrpotes commented Feb 16, 2018

When trying to use Guartz with Guice 4, you get the following exception:

java.lang.ClassNotFoundException: com.google.inject.internal.util.$Preconditions
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:560)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at org.nnsoft.guice.guartz.QuartzModule.configure(QuartzModule.java:59)
	at com.google.inject.AbstractModule.configure(AbstractModule.java:62)
...

This is because Guice 4 uses Guava, rather than having internal classes that it has to maintain. Please can you accept these contributions from @awillinger to uplift versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants