[DRAFT] AddingMagneticMACE #1244
Open
CheukHinHoJerry wants to merge 7 commits intoACEsuit:developfrom
Open
Conversation
Contributor
|
Hey @CheukHinHoJerry thank you very much for that. Yes the model should be in the extensions.py, the new blocks themselves can be in blocks.py. For the random rotations, could please create a new file in data folder called augmentations.py where you put it? thank you |
Collaborator
Author
|
No problem - I will make those changes and let you know. Thank you for the quick comment. |
Collaborator
Author
|
@ilyes319 I turned on precommit checks but there are too many lines in |
MagneticMACE MagneticMACE
Contributor
|
@CheukHinHoJerry Yep you can disable that for that file! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
MagneticMACEas abstract class with other spin-informed variant of magnetic MACE. Major changes areThis PR is still WIP because I am not sure how one would like to place the code and I am current at the stage of adding some tests , happy to make changes.
Questions in my mind for @ilyes319 atm:
extension.pytoo? Or should they be placed where they are supposed to be outsideextension.py?