Fix links to 'Reaching The Ground With Lightning' #3219
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
fix-link-in-resources
branch
from
d3f8f9a to
8ac4757
Compare
ekzyis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed that the links to 'Reaching The Ground With Lightning' in README.md and CONTRIBUTING.md were broken because the file was moved in ElementsProject/lightning@9e47c16.
I now used a permalink so the links will not break again. However, that also means if the PDF gets updated, the links will still point to the old version.
However, since the PDF has not been changed meaningfully in 10 years (last time in ElementsProject/lightning@2ab9e3b), I don't think that's ever going to happen again.
But if it happens, I think working links are more important anyway.
I also searched for
deployable-lightning.pdfto check if there's another broken link, but I didn't find any.